Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[705] Api version enforcement update #706

Merged
merged 5 commits into from
Jan 23, 2023
Merged

[705] Api version enforcement update #706

merged 5 commits into from
Jan 23, 2023

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Jan 20, 2023 •
edited
Loading

Content

This PR changes how aggregator check for api version incompatibility.

Instead of using a strict comparison, it check if the:

  • the major is the same (for 'stable' versions, with a major of 1 or more).
  • the major & minor are the same (for 'beta' versions, with a major of 0).

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #705

@github-actions
Copy link

github-actions bot commented Jan 20, 2023 •
edited
Loading

Test Results

    3 files  ±0    28 suites  ±0   5m 57s ⏱️ +27s
405 tests +4  405 ✔️ +4  0 💤 ±0  0 ❌ ±0 
470 runs  +4  470 ✔️ +4  0 💤 ±0  0 ❌ ±0 

Results for commit c2c99ea. ± Comparison against base commit 25f2d34.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview January 20, 2023 17:16 — with GitHub Actions Inactive
@Alenar Alenar force-pushed the djo/705/api_version_enforcement_update_ branch from 870ece6 to 2138363 Compare January 23, 2023 09:01
@Alenar Alenar temporarily deployed to testing-preview January 23, 2023 09:10 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar force-pushed the djo/705/api_version_enforcement_update_ branch from 2138363 to c2c99ea Compare January 23, 2023 09:23
@Alenar Alenar temporarily deployed to testing-preview January 23, 2023 09:42 — with GitHub Actions Inactive
@Alenar Alenar merged commit 88a1696 into main Jan 23, 2023
@Alenar Alenar deleted the djo/705/api_version_enforcement_update_ branch January 23, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update enforcement of API version with Semver
3 participants
@Alenar @jpraynaud @ghubertpalo