Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy warnings from Rust 1.67.0 #714

Merged
merged 8 commits into from
Jan 30, 2023
Merged

Fix clippy warnings from Rust 1.67.0 #714

merged 8 commits into from
Jan 30, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 26, 2023 •
edited
Loading

Content

This PR includes a fix to remove clippy warnings that arose with the new version of Rust 1.67.0

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Jan 26, 2023
@github-actions
Copy link

github-actions bot commented Jan 26, 2023 •
edited
Loading

Test Results

    3 files  ±0    28 suites  ±0   4m 47s ⏱️ -36s
413 tests ±0  413 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
480 runs  ±0  480 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 35eadff. ± Comparison against base commit 909e141.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/fix-clippy-warnings-rust-1.67.0 branch from d865081 to 72667f4 Compare January 26, 2023 17:32
@jpraynaud jpraynaud temporarily deployed to testing-preview January 26, 2023 18:04 — with GitHub Actions Inactive
iquerejeta
iquerejeta approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@iquerejeta iquerejeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud temporarily deployed to testing-preview January 30, 2023 09:23 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 513e09c into main Jan 30, 2023
@jpraynaud jpraynaud deleted the jpraynaud/fix-clippy-warnings-rust-1.67.0 branch January 30, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

@iquerejeta iquerejeta iquerejeta approved these changes

@Alenar Alenar Alenar approved these changes

@curiecrypt curiecrypt Awaiting requested review from curiecrypt

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpraynaud @Alenar @iquerejeta @ghubertpalo