Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize mithril-stm multi_sig.rs #719

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Reorganize mithril-stm multi_sig.rs #719

merged 1 commit into from
Jan 31, 2023

Conversation

curiecrypt
Copy link
Collaborator

@curiecrypt curiecrypt commented Jan 31, 2023 •
edited
Loading

Content

This PR reorganize the order of the structs and implementations in multi_sig.rs.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@curiecrypt curiecrypt requested a review from iquerejeta January 31, 2023 14:24
@github-actions
Copy link

Test Results

    3 files  ±0    28 suites  ±0   4m 54s ⏱️ -44s
416 tests ±0  416 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
483 runs  ±0  483 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit edd88eb. ± Comparison against base commit 30f6152.

@curiecrypt curiecrypt temporarily deployed to testing-preview January 31, 2023 14:35 — with GitHub Actions Inactive
iquerejeta
iquerejeta approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@iquerejeta iquerejeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@curiecrypt curiecrypt merged commit e66763b into main Jan 31, 2023
@curiecrypt curiecrypt deleted the reorganize-multisig branch January 31, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iquerejeta iquerejeta iquerejeta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curiecrypt @iquerejeta