Fix 'UnregisteredInitializer' error on signer #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a protocol initializer: this avoids preventing signer from signing when it is not registered for the next epoch and returning a 'UnregisteredInitializer' error.
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
ghubertpalo
approved these changes
Feb 13, 2023
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
deleted the
jpraynaud/730-fix-unregistered-initializer-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix to the error received by some signers when attempting to create a single signature:
ProtocolInitializerNotRegistered(CoreRegister(UnregisteredInitializer))After investigation, it appears that this error occurs when a signer is signing a message and is not registered for the next epoch: in that case the signer should be able to sign and should only skip signing at the next epoch. The fix replaces the usage of a protocol initializer with a clerk instead to compute the aggregate verification key that is embedded in the signed message.
Pre-submit checklist
Issue(s)
Closes #730