Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add era command in aggregator cli #756

Merged
merged 6 commits into from
Feb 21, 2023
Merged

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Feb 16, 2023

Content

This PR includes a Era command in the aggregator cli that:

  • Lists the supported eras
  • Generate a TxDatum JSON that can be used in an on-chain transaction

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #755

@github-actions
Copy link

github-actions bot commented Feb 16, 2023

Test Results

    3 files  ±0    28 suites  ±0   5m 2s ⏱️ -43s
441 tests +4  441 ✔️ +4  0 💤 ±0  0 ±0 
509 runs  +4  509 ✔️ +4  0 💤 ±0  0 ±0 

Results for commit a325ca7. ± Comparison against base commit 87938ad.

This pull request removes 1 and adds 5 tests. Note that renamed tests count towards both.
era::supported_era::tests ‑ from_bad_str
chain_observer::model::test ‑ test_build_tx_datum
era::supported_era::tests ‑ correct_number_of_eras
tools::era::tests ‑ generate_tx_datum_ok
tools::era::tests ‑ generate_tx_datum_wrong_epochs
tools::era::tests ‑ get_supported_eras_list

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview February 16, 2023 17:27 — with GitHub Actions Inactive
@jpraynaud jpraynaud self-assigned this Feb 17, 2023
@jpraynaud jpraynaud force-pushed the jpraynaud/755-era-cli-command branch from 7542b93 to ed6d680 Compare February 17, 2023 16:42
@jpraynaud jpraynaud temporarily deployed to testing-preview February 17, 2023 17:07 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/755-era-cli-command branch from 20c9216 to 09eab38 Compare February 20, 2023 17:14
@jpraynaud jpraynaud marked this pull request as ready for review February 20, 2023 17:17
@jpraynaud jpraynaud temporarily deployed to testing-preview February 20, 2023 17:31 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/755-era-cli-command branch from 09eab38 to a325ca7 Compare February 21, 2023 09:13
@jpraynaud jpraynaud temporarily deployed to testing-preview February 21, 2023 09:21 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit d991b2e into main Feb 21, 2023
@jpraynaud jpraynaud deleted the jpraynaud/755-era-cli-command branch February 21, 2023 09:28
jpraynaud added a commit that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Era cli command in aggregator
2 participants