Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#743 monitor stake distribution Vs Signer version #759

Merged
merged 4 commits into from
Feb 21, 2023
Merged

#743 monitor stake distribution Vs Signer version #759

merged 4 commits into from
Feb 21, 2023

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented Feb 20, 2023 •
edited
Loading

Content

This PR includes a tool to monitor the distribution of the stake distribution against the signers node versions.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Issue(s)

Relates to #YYY or Closes #YYY

@ghubertpalo ghubertpalo temporarily deployed to testing-preview February 20, 2023 11:28 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 20, 2023 •
edited
Loading

Test Results

    3 files  ±0    28 suites  ±0   5m 14s ⏱️ -29s
441 tests ±0  441 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
509 runs  ±0  509 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 97ad096. ± Comparison against base commit d991b2e.

♻️ This comment has been updated with latest results.

jpraynaud
jpraynaud approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo force-pushed the greg/743/extract_stake_distribution branch from c5340eb to 6a8f73d Compare February 21, 2023 13:14
@ghubertpalo ghubertpalo force-pushed the greg/743/extract_stake_distribution branch from 6a8f73d to 97ad096 Compare February 21, 2023 13:28
@ghubertpalo ghubertpalo temporarily deployed to testing-preview February 21, 2023 14:20 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo merged commit feb1e00 into main Feb 21, 2023
@ghubertpalo ghubertpalo deleted the greg/743/extract_stake_distribution branch February 21, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghubertpalo @jpraynaud