Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for batch verify #774

Merged
merged 4 commits into from
Feb 27, 2023
Merged

test for batch verify #774

merged 4 commits into from
Feb 27, 2023

Conversation

curiecrypt
Copy link
Collaborator

@curiecrypt curiecrypt commented Feb 24, 2023

Content

This PR enhances the test of full stm protocol:

  • The name of the file../tests/integrations.rs changed to ../tests/test_full_protocol.rs,
  • The functions initialization_phase() and operation_phase() are added,
  • test_full_protocol() is updated to call the above functions for initialization and operation,
  • A new test test_full_protocol_batch_verify() is added.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

test_full_protocol_batch_verify() :

  • could check the batch verify as in test_full_protocol,
  • Parameters could be changed for each batch.

Issue(s)

Closes #724

@github-actions
Copy link

github-actions bot commented Feb 24, 2023

Test Results

    3 files  ±0    28 suites  ±0   5m 57s ⏱️ +14s
442 tests +1  442 ✔️ +1  0 💤 ±0  0 ±0 
510 runs  +1  510 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit fcb4134. ± Comparison against base commit 220dafa.

♻️ This comment has been updated with latest results.

@curiecrypt curiecrypt temporarily deployed to testing-preview February 24, 2023 15:36 — with GitHub Actions Inactive
@iquerejeta iquerejeta force-pushed the test-batch-verify-stm branch from 8cafa96 to 705088d Compare February 27, 2023 10:33
@iquerejeta iquerejeta temporarily deployed to testing-preview February 27, 2023 10:40 — with GitHub Actions Inactive
@iquerejeta iquerejeta force-pushed the test-batch-verify-stm branch from bdddb0c to fcb4134 Compare February 27, 2023 11:38
@iquerejeta iquerejeta temporarily deployed to testing-preview February 27, 2023 11:47 — with GitHub Actions Inactive
Copy link
Contributor

@iquerejeta iquerejeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

@iquerejeta iquerejeta merged commit a555e0b into main Feb 27, 2023
@iquerejeta iquerejeta deleted the test-batch-verify-stm branch February 27, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance tests of mithril-stm to cover batch verify
2 participants