Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker Client crash #792

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Mar 9, 2023

Content

This PR includes:

  • A fix to the Docker Client image that crashes because of missing home directory for the appuser
  • An update to the documentation with Docker images usage in:

The Mithril Client multi-platform test GitHub action will be updated to also test the behavior of the Docker Client image.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)

Issue(s)

Closes #791

Fix home 'appuser' directory not existing but needed for snapshot digest cache.
@jpraynaud jpraynaud requested a review from ghubertpalo March 9, 2023 11:11
@jpraynaud jpraynaud force-pushed the jpraynaud/791-fix-docker-client-crash branch from a715dda to 61e7785 Compare March 9, 2023 11:13
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Test Results

    3 files  ±0    30 suites  ±0   5m 19s ⏱️ -41s
446 tests ±0  446 ✔️ ±0  0 💤 ±0  0 ±0 
516 runs  ±0  516 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 61e7785. ± Comparison against base commit 8fd902c.

@jpraynaud jpraynaud temporarily deployed to testing-preview March 9, 2023 11:24 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 7a871b2 into main Mar 9, 2023
@jpraynaud jpraynaud deleted the jpraynaud/791-fix-docker-client-crash branch March 9, 2023 13:27
@jpraynaud jpraynaud self-assigned this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mithril client fails to restore snapshot.
2 participants