Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy warnings from Rust 1.68.0 #795

Merged
merged 5 commits into from
Mar 10, 2023
Merged

Fix clippy warnings from Rust 1.68.0 #795

merged 5 commits into from
Mar 10, 2023

Conversation

jpraynaud
Copy link
Member

Content

This PR includes a fix to remove clippy warnings that arose with the new version of Rust 1.68.0

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

iquerejeta
iquerejeta approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@iquerejeta iquerejeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud self-assigned this Mar 9, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023 •
edited
Loading

Test Results

    3 files  ±0    30 suites  ±0   5m 50s ⏱️ -40s
446 tests ±0  446 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
516 runs  ±0  516 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0eb2af3. ± Comparison against base commit 7a871b2.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/fix-clippy-warnings-rust-1.68.0 branch from 3560a18 to 0eb2af3 Compare March 9, 2023 18:17
@jpraynaud jpraynaud temporarily deployed to testing-preview March 9, 2023 18:32 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit f6a3a34 into main Mar 10, 2023
@jpraynaud jpraynaud deleted the jpraynaud/fix-clippy-warnings-rust-1.68.0 branch March 10, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iquerejeta iquerejeta iquerejeta approved these changes

@curiecrypt curiecrypt Awaiting requested review from curiecrypt

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpraynaud @iquerejeta