Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#799 stake pool service #800

Merged
merged 3 commits into from
Mar 23, 2023
Merged

#799 stake pool service #800

merged 3 commits into from
Mar 23, 2023

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented Mar 14, 2023 •
edited
Loading

Content

This PR includes a refactoring to manage stakes from a dedicated service out of the MultiSigner.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

None

Issue(s)

Closes #799

@ghubertpalo ghubertpalo force-pushed the greg/799/stake_pool_service branch from fe253e3 to 61b2717 Compare March 14, 2023 16:11
@ghubertpalo ghubertpalo requested a review from jpraynaud March 14, 2023 16:11
@ghubertpalo ghubertpalo force-pushed the greg/799/stake_pool_service branch from 61b2717 to 2564013 Compare March 14, 2023 16:14
@github-actions
Copy link

github-actions bot commented Mar 14, 2023 •
edited
Loading

Test Results

    3 files  ±0    30 suites  ±0   5m 5s ⏱️ -32s
483 tests +7  483 ✔️ +7  0 💤 ±0  0 ❌ ±0 
559 runs  +7  559 ✔️ +7  0 💤 ±0  0 ❌ ±0 

Results for commit 8f296a9. ± Comparison against base commit b9dee08.

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo force-pushed the greg/799/stake_pool_service branch from 2564013 to 148578c Compare March 15, 2023 09:00
@ghubertpalo ghubertpalo temporarily deployed to testing-preview March 15, 2023 09:13 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo force-pushed the greg/799/stake_pool_service branch from 6cfa5e1 to ba107a3 Compare March 15, 2023 13:27
@ghubertpalo ghubertpalo temporarily deployed to testing-preview March 15, 2023 13:35 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mithril-aggregator/src/database/provider/stake_pool.rs Outdated Show resolved Hide resolved
@ghubertpalo ghubertpalo force-pushed the greg/799/stake_pool_service branch from ba107a3 to 2ac1fc6 Compare March 15, 2023 13:58
@ghubertpalo ghubertpalo temporarily deployed to testing-preview March 15, 2023 14:23 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo mentioned this pull request Mar 15, 2023
Merged
11 tasks
@ghubertpalo ghubertpalo marked this pull request as draft March 15, 2023 14:35
@ghubertpalo ghubertpalo temporarily deployed to testing-preview March 15, 2023 16:35 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo mentioned this pull request Mar 16, 2023
Merged
11 tasks
@ghubertpalo ghubertpalo force-pushed the greg/799/stake_pool_service branch from 67b44a8 to bcad6b1 Compare March 16, 2023 09:40
@ghubertpalo ghubertpalo temporarily deployed to testing-preview March 16, 2023 09:47 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo reopened this Mar 17, 2023
@ghubertpalo ghubertpalo temporarily deployed to testing-preview March 17, 2023 09:41 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo temporarily deployed to testing-preview March 17, 2023 16:13 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo force-pushed the greg/799/stake_pool_service branch from d7c23ff to 91853b5 Compare March 22, 2023 12:42
@ghubertpalo ghubertpalo temporarily deployed to testing-preview March 22, 2023 16:46 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo marked this pull request as ready for review March 23, 2023 08:22
@ghubertpalo ghubertpalo force-pushed the greg/799/stake_pool_service branch from 792b320 to 8f296a9 Compare March 23, 2023 08:37
jpraynaud
jpraynaud approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo temporarily deployed to testing-preview March 23, 2023 08:46 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo merged commit 2322b54 into main Mar 23, 2023
@ghubertpalo ghubertpalo deleted the greg/799/stake_pool_service branch March 23, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@jpraynaud jpraynaud

@ghubertpalo ghubertpalo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Stake Distribution service
2 participants
@ghubertpalo @jpraynaud