Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create/Migrate signed_entity store #858

Merged
merged 7 commits into from
Apr 11, 2023
Merged

Create/Migrate signed_entity store #858

merged 7 commits into from
Apr 11, 2023

Conversation

jpraynaud
Copy link
Member

Content

This PR includes the following steps:

  • Create the signed_entity table
  • Migrate the signed_entity table
  • Implement SignedEntityStore providers
  • Implement SignedEntityStore adapter
  • Wire SignedEntityStore as the new SnapshotStore dependency

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #816

@jpraynaud jpraynaud self-assigned this Apr 7, 2023
@jpraynaud jpraynaud requested a review from ghubertpalo April 7, 2023 14:25
@github-actions
Copy link

github-actions bot commented Apr 7, 2023 •
edited
Loading

Test Results

    3 files  ±0    30 suites  ±0   5m 9s ⏱️ -15s
529 tests +8  529 ✔️ +8  0 💤 ±0  0 ❌ ±0 
605 runs  +8  605 ✔️ +8  0 💤 ±0  0 ❌ ±0 

Results for commit 99552bc. ± Comparison against base commit d1c6af7.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview April 7, 2023 14:35 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/816-adapt-signed-entity-stores branch from 5724dfe to 5f9f101 Compare April 11, 2023 13:08
@jpraynaud jpraynaud temporarily deployed to testing-preview April 11, 2023 13:20 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/816-adapt-signed-entity-stores branch from 5f9f101 to 99552bc Compare April 11, 2023 13:25
@jpraynaud jpraynaud temporarily deployed to testing-preview April 11, 2023 13:40 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit e2eca8b into main Apr 11, 2023
@jpraynaud jpraynaud deleted the jpraynaud/816-adapt-signed-entity-stores branch April 11, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate/adapt signed_entity table
2 participants
@jpraynaud @ghubertpalo