Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#850 Certifier service #866

Merged
merged 26 commits into from
Apr 27, 2023
Merged

#850 Certifier service #866

merged 26 commits into from
Apr 27, 2023

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented Apr 17, 2023

Content

This PR adds the Certifier Service that can certify multiple types of data.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #850

@github-actions
Copy link

github-actions bot commented Apr 17, 2023

Test Results

    3 files  ±  0    30 suites  ±0   6m 2s ⏱️ +41s
563 tests +14  563 ✔️ +14  0 💤 ±0  0 ±0 
639 runs  +14  639 ✔️ +14  0 💤 ±0  0 ±0 

Results for commit 770b330. ± Comparison against base commit 01921eb.

This pull request removes 8 and adds 22 tests. Note that renamed tests count towards both.
certificate_creator::tests ‑ test
http_server::routes::signatures_routes::tests ‑ test_register_signatures_post_ko_409
multi_signer::tests ‑ test_multi_signer_current_message_ok
runtime::runner::tests ‑ test_create_and_save_certificate_ok
runtime::runner::tests ‑ test_create_new_working_certificate
runtime::runner::tests ‑ test_create_new_working_certificate_ko_epoch_gap
runtime::runner::tests ‑ test_update_message_in_multisigner
runtime::state_machine::tests ‑ signing_multisig_is_created
certifier_service::tests ‑ should_clean_epoch_when_inform_new_epoch
certifier_service::tests ‑ should_create_certificate_when_multi_signature_produced
certifier_service::tests ‑ should_not_clean_epoch_when_inform_same_epoch
certifier_service::tests ‑ should_not_create_certificate_for_open_message_already_certified
certifier_service::tests ‑ should_not_create_certificate_for_open_message_not_created
certifier_service::tests ‑ should_not_create_certificate_when_no_multi_signature_produced
certifier_service::tests ‑ should_not_register_invalid_single_signature
certifier_service::tests ‑ should_not_register_single_signature_for_certified_open_message
certifier_service::tests ‑ should_register_valid_single_signature
database::provider::certificate::tests ‑ get_master_certificate_for_epoch
…

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo force-pushed the ensemble/850/certifier_service branch from 93df2dd to cbf1a33 Compare April 18, 2023 07:41
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@jpraynaud jpraynaud force-pushed the ensemble/850/certifier_service branch from 372bfa5 to c1fb510 Compare April 19, 2023 10:29
@jpraynaud jpraynaud force-pushed the ensemble/850/certifier_service branch from 00684bd to fefef9e Compare April 19, 2023 16:29
@jpraynaud jpraynaud force-pushed the ensemble/850/certifier_service branch from 179735c to 9b0358a Compare April 21, 2023 16:55
@jpraynaud jpraynaud force-pushed the ensemble/850/certifier_service branch 2 times, most recently from 0bb936f to 867286f Compare April 24, 2023 15:58
@Alenar Alenar force-pushed the ensemble/850/certifier_service branch from 631c05e to 9f02c0f Compare April 25, 2023 12:30
@jpraynaud jpraynaud force-pushed the ensemble/850/certifier_service branch from 9fc8298 to a58808b Compare April 26, 2023 09:26
@jpraynaud jpraynaud temporarily deployed to testing-preview April 26, 2023 09:34 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the ensemble/850/certifier_service branch 2 times, most recently from c31cf11 to 74159f6 Compare April 26, 2023 10:17
@jpraynaud jpraynaud temporarily deployed to testing-preview April 26, 2023 10:53 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the ensemble/850/certifier_service branch from 74159f6 to 3169d75 Compare April 26, 2023 13:47
@jpraynaud jpraynaud temporarily deployed to testing-preview April 26, 2023 14:09 — with GitHub Actions Inactive
@jpraynaud jpraynaud requested review from Alenar and jpraynaud April 26, 2023 14:39
@jpraynaud jpraynaud temporarily deployed to testing-preview April 26, 2023 14:48 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud force-pushed the ensemble/850/certifier_service branch from 602d1b3 to 770b330 Compare April 26, 2023 15:12
@jpraynaud jpraynaud temporarily deployed to testing-preview April 26, 2023 16:00 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 0a209ca into main Apr 27, 2023
@jpraynaud jpraynaud deleted the ensemble/850/certifier_service branch April 27, 2023 07:46
@Alenar Alenar mentioned this pull request Apr 27, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Certifier service in aggregator
3 participants