Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Signer Registration Discrepancy #877

Merged
merged 8 commits into from
Apr 27, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Apr 26, 2023

Content

This PR includes a fix to the verification key discrepancy that happens sporadically between signer and aggregator, and that prevents some signers to participate in the signature process for an epoch.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #873

@jpraynaud jpraynaud self-assigned this Apr 26, 2023
@jpraynaud jpraynaud changed the base branch from main to ensemble/850/certifier_service April 26, 2023 17:00
@github-actions
Copy link

github-actions bot commented Apr 26, 2023

Test Results

    3 files  ±0    30 suites  ±0   5m 46s ⏱️ -1s
567 tests +1  567 ✔️ +1  0 💤 ±0  0 ±0 
643 runs  +1  643 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit e1cd99d. ± Comparison against base commit e262899.

♻️ This comment has been updated with latest results.

Base automatically changed from ensemble/850/certifier_service to main April 27, 2023 07:46
@jpraynaud jpraynaud force-pushed the jpraynaud/873-fix-verification-key-discrepancy branch from fc69b1d to 9c5aa0c Compare April 27, 2023 09:43
@jpraynaud jpraynaud marked this pull request as ready for review April 27, 2023 09:46
@jpraynaud jpraynaud force-pushed the jpraynaud/873-fix-verification-key-discrepancy branch from 9c5aa0c to e2def60 Compare April 27, 2023 14:24
@jpraynaud jpraynaud force-pushed the jpraynaud/873-fix-verification-key-discrepancy branch from e2def60 to 7e2f46e Compare April 27, 2023 14:28
@jpraynaud jpraynaud requested review from ghubertpalo and Alenar April 27, 2023 14:30
@jpraynaud jpraynaud temporarily deployed to testing-preview April 27, 2023 14:40 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/873-fix-verification-key-discrepancy branch from 7e2f46e to 2dba1e5 Compare April 27, 2023 15:13
@jpraynaud jpraynaud force-pushed the jpraynaud/873-fix-verification-key-discrepancy branch from 2dba1e5 to 363d248 Compare April 27, 2023 15:15
@jpraynaud jpraynaud force-pushed the jpraynaud/873-fix-verification-key-discrepancy branch from 363d248 to e1cd99d Compare April 27, 2023 15:20
@jpraynaud jpraynaud temporarily deployed to testing-preview April 27, 2023 15:29 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit ab9d05b into main Apr 27, 2023
@jpraynaud jpraynaud deleted the jpraynaud/873-fix-verification-key-discrepancy branch April 27, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verification key discrepancy between signer and aggregator
3 participants