-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Signer Registration Discrepancy #877
Merged
jpraynaud
merged 8 commits into
main
from
jpraynaud/873-fix-verification-key-discrepancy
Apr 27, 2023
Merged
Fix Signer Registration Discrepancy #877
jpraynaud
merged 8 commits into
main
from
jpraynaud/873-fix-verification-key-discrepancy
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpraynaud
force-pushed
the
jpraynaud/873-fix-verification-key-discrepancy
branch
from
April 27, 2023 09:43
fc69b1d
to
9c5aa0c
Compare
And enforce epoch compliance when registering.
jpraynaud
force-pushed
the
jpraynaud/873-fix-verification-key-discrepancy
branch
from
April 27, 2023 14:24
9c5aa0c
to
e2def60
Compare
jpraynaud
force-pushed
the
jpraynaud/873-fix-verification-key-discrepancy
branch
from
April 27, 2023 14:28
e2def60
to
7e2f46e
Compare
jpraynaud
temporarily deployed
to
testing-preview
April 27, 2023 14:40 — with
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/873-fix-verification-key-discrepancy
branch
from
April 27, 2023 15:13
7e2f46e
to
2dba1e5
Compare
ghubertpalo
approved these changes
Apr 27, 2023
jpraynaud
force-pushed
the
jpraynaud/873-fix-verification-key-discrepancy
branch
from
April 27, 2023 15:15
2dba1e5
to
363d248
Compare
Alenar
approved these changes
Apr 27, 2023
jpraynaud
force-pushed
the
jpraynaud/873-fix-verification-key-discrepancy
branch
from
April 27, 2023 15:20
363d248
to
e1cd99d
Compare
jpraynaud
temporarily deployed
to
testing-preview
April 27, 2023 15:29 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix to the verification key discrepancy that happens sporadically between signer and aggregator, and that prevents some signers to participate in the signature process for an epoch.
Pre-submit checklist
Issue(s)
Closes #873