Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mithril Stake Distribution Signable builder #885

Merged
merged 6 commits into from
May 3, 2023
Merged

Mithril Stake Distribution Signable builder #885

merged 6 commits into from
May 3, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Apr 28, 2023 •
edited
Loading

Content

This PR includes the implementation of:

  • Mithril Stake Distribution Signable builder in signer

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #851

@jpraynaud jpraynaud self-assigned this Apr 28, 2023
@github-actions
Copy link

github-actions bot commented Apr 28, 2023 •
edited
Loading

Test Results

    3 files  ±0    30 suites  ±0   6m 19s ⏱️ +53s
565 tests ±0  565 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
641 runs  ±0  641 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c03101c. ± Comparison against base commit cc9660f.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview April 28, 2023 10:42 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/851-signable-artifact-builder-mithril-stake-distribution-signer branch from 9874b28 to b08516d Compare May 2, 2023 12:40
@jpraynaud jpraynaud temporarily deployed to testing-preview May 2, 2023 12:48 — with GitHub Actions Inactive
@jpraynaud jpraynaud requested review from Alenar and ghubertpalo May 2, 2023 12:49
@jpraynaud jpraynaud marked this pull request as ready for review May 2, 2023 12:49
@jpraynaud jpraynaud changed the title Mithril Stake Distribution Signable builder in signer Mithril Stake Distribution Signable builder May 2, 2023
@jpraynaud jpraynaud force-pushed the jpraynaud/851-signable-artifact-builder-mithril-stake-distribution-signer branch from b08516d to ce868b6 Compare May 2, 2023 16:18
@jpraynaud jpraynaud temporarily deployed to testing-preview May 2, 2023 16:28 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/851-signable-artifact-builder-mithril-stake-distribution-signer branch from ce868b6 to 513e169 Compare May 2, 2023 19:10
@jpraynaud jpraynaud temporarily deployed to testing-preview May 2, 2023 19:19 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/851-signable-artifact-builder-mithril-stake-distribution-signer branch from 513e169 to c03101c Compare May 3, 2023 08:53
@jpraynaud jpraynaud requested a review from ghubertpalo May 3, 2023 08:58
@jpraynaud jpraynaud temporarily deployed to testing-preview May 3, 2023 09:10 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit e7c947f into main May 3, 2023
@jpraynaud jpraynaud deleted the jpraynaud/851-signable-artifact-builder-mithril-stake-distribution-signer branch May 3, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

@Alenar Alenar Awaiting requested review from Alenar

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement signable builder for Mithril Stake Distribution
2 participants
@jpraynaud @ghubertpalo