Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add signable builder in signer #891

Merged
merged 3 commits into from
May 2, 2023

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented May 2, 2023

Content

This PR includes add SignableBuilder in the Signer binary.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Implementation done, not yet used by the runner system.

Issue(s)

Relates to #852

@github-actions
Copy link

github-actions bot commented May 2, 2023

Test Results

    3 files  ±0    30 suites  ±0   6m 11s ⏱️ +57s
565 tests ±0  565 ✔️ ±0  0 💤 ±0  0 ±0 
641 runs  ±0  641 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 79a4128. ± Comparison against base commit 0173a98.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
signable_builder::immutable_signable_builder::tests ‑ compute_signable
signable_builder::cardano_immutable_full_signable_builder::tests ‑ compute_signable

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo temporarily deployed to testing-preview May 2, 2023 10:00 — with GitHub Actions Inactive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should stick to the nomenclature given by the signed entity types for clarity, and rename to CardanoImmutableFilesFullSignableBuilder?

@ghubertpalo ghubertpalo changed the title add sigable builder in signer add signable builder in signer May 2, 2023
@ghubertpalo ghubertpalo force-pushed the ensemble/852/immutable_signable_signer branch from 9b3d21f to 25f1c72 Compare May 2, 2023 14:51
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo force-pushed the ensemble/852/immutable_signable_signer branch from 25f1c72 to 98fcc8e Compare May 2, 2023 15:00
@ghubertpalo ghubertpalo force-pushed the ensemble/852/immutable_signable_signer branch from 98fcc8e to 79a4128 Compare May 2, 2023 15:03
@ghubertpalo ghubertpalo temporarily deployed to testing-preview May 2, 2023 15:11 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo merged commit b679c45 into main May 2, 2023
@ghubertpalo ghubertpalo deleted the ensemble/852/immutable_signable_signer branch May 2, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants