-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add signable builder in signer #891
Conversation
Test Results 3 files ±0 30 suites ±0 6m 11s ⏱️ +57s Results for commit 79a4128. ± Comparison against base commit 0173a98. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should stick to the nomenclature given by the signed entity types for clarity, and rename to CardanoImmutableFilesFullSignableBuilder
?
9b3d21f
to
25f1c72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
25f1c72
to
98fcc8e
Compare
98fcc8e
to
79a4128
Compare
Content
This PR includes add SignableBuilder in the Signer binary.
Pre-submit checklist
Comments
Implementation done, not yet used by the runner system.
Issue(s)
Relates to #852