Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardano Immutable Files Full Artifact builder in aggregator #900

Merged

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented May 3, 2023

Content

This PR includes the implementation of:

  • Cardano Immutable Files Full Artifact builder in aggregator

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #871

@jpraynaud jpraynaud requested review from Alenar and ghubertpalo and removed request for Alenar and ghubertpalo May 3, 2023 15:03
@github-actions
Copy link

github-actions bot commented May 3, 2023

Test Results

    3 files  ±0    30 suites  ±0   5m 58s ⏱️ +5s
569 tests +4  569 ✔️ +4  0 💤 ±0  0 ±0 
645 runs  +4  645 ✔️ +4  0 💤 ±0  0 ±0 

Results for commit 9f71e91. ± Comparison against base commit e7c947f.

This pull request removes 2 and adds 6 tests. Note that renamed tests count towards both.
artifact_builder::artifact_builder_service::tests ‑ test_artifact_builder_service_mithril_stake_distribution
artifact_builder::mithril_stake_distribution::tests ‑ test_compute_artifact
artifact_builder::artifact_builder_service::tests ‑ build_mithril_stake_distribution_artifact_when_given_mithril_stake_distribution_entity_type
artifact_builder::artifact_builder_service::tests ‑ build_snapshot_artifact_when_given_cardano_immutable_files_full_entity_type
artifact_builder::cardano_immutable_files_full::tests ‑ remove_snapshot_archive_after_upload
artifact_builder::cardano_immutable_files_full::tests ‑ should_compute_valid_artifact
artifact_builder::cardano_immutable_files_full::tests ‑ snapshot_archive_name_after_beacon_values
artifact_builder::mithril_stake_distribution::tests ‑ should_compute_valid_artifact

@jpraynaud jpraynaud temporarily deployed to testing-preview May 3, 2023 15:40 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 0c2476b into main May 3, 2023
@jpraynaud jpraynaud deleted the ensemble/871-artifact-builder-cardano-full-immutables branch May 3, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants