Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Signable Builder Service in aggregator #901

Merged
merged 4 commits into from
May 4, 2023
Merged

Use Signable Builder Service in aggregator #901

merged 4 commits into from
May 4, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented May 4, 2023 •
edited
Loading

Content

This PR includes the use of the Signable Builder Service by the aggregtaor runtime to compute protocol messages given a signed entity type

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #853

@jpraynaud jpraynaud requested review from ghubertpalo and Alenar May 4, 2023 08:55
@github-actions
Copy link

github-actions bot commented May 4, 2023 •
edited
Loading

Test Results

    3 files  ±0    30 suites  ±0   5m 57s ⏱️ +33s
571 tests +2  571 ✔️ +2  0 💤 ±0  0 ❌ ±0 
647 runs  +2  647 ✔️ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 2849055. ± Comparison against base commit 0c2476b.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview May 4, 2023 09:06 — with GitHub Actions Inactive
jpraynaud added 2 commits May 4, 2023 11:10
@jpraynaud
Refactor remove Signable trait
53c6db3 
Which is not needed anymore as Signable Builder returns a ProtocolMessage directly.
@jpraynaud
Bump crates versions
2849055
@jpraynaud jpraynaud force-pushed the ensemble/853-use-signable-builder-service-aggregator branch from 631c62b to 2849055 Compare May 4, 2023 09:14
@jpraynaud jpraynaud temporarily deployed to testing-preview May 4, 2023 09:28 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 0ab4ef1 into main May 4, 2023
@jpraynaud jpraynaud deleted the ensemble/853-use-signable-builder-service-aggregator branch May 4, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees

@Alenar Alenar

@jpraynaud jpraynaud

@ghubertpalo ghubertpalo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt runtime to use signable builder service in aggregator
3 participants
@jpraynaud @Alenar @ghubertpalo