Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new Stake Distribution computation #921

Merged
merged 4 commits into from
May 15, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented May 11, 2023

Content

This PR includes the implementation of the new Stake Distribution computation:

  • Use the new query stake-snapshot --all-stake-pools command when available (Cardano node 8.0.0+)
  • Fallback on the (now) legacy former computation of the Stake Distribution otherwise (Cardano node 1.35.7-)

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Add dev blog post (if relevant)

Issue(s)

Closes #919

@jpraynaud jpraynaud self-assigned this May 11, 2023
@github-actions
Copy link

github-actions bot commented May 11, 2023

Test Results

    3 files  ±0    30 suites  ±0   5m 24s ⏱️ -50s
584 tests +2  584 ✔️ +2  0 💤 ±0  0 ±0 
660 runs  +2  660 ✔️ +2  0 💤 ±0  0 ±0 

Results for commit 1c33b46. ± Comparison against base commit 65e508e.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview May 11, 2023 16:23 — with GitHub Actions Inactive
@jpraynaud jpraynaud requested review from Alenar and ghubertpalo May 11, 2023 16:24
@jpraynaud jpraynaud marked this pull request as ready for review May 11, 2023 16:24
@jpraynaud jpraynaud force-pushed the jpraynaud/919-new-stake-distribution-computation branch from c9cf683 to 7afd764 Compare May 12, 2023 08:32
@jpraynaud jpraynaud temporarily deployed to testing-preview May 12, 2023 08:40 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview May 12, 2023 16:57 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/919-new-stake-distribution-computation branch from 33cf29f to 1c33b46 Compare May 15, 2023 07:59
@jpraynaud jpraynaud temporarily deployed to testing-preview May 15, 2023 08:14 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 54e8cf9 into main May 15, 2023
@jpraynaud jpraynaud deleted the jpraynaud/919-new-stake-distribution-computation branch May 15, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new stake distribution computation in the ChainObserver
2 participants