Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Artifact routes #924

Merged
merged 9 commits into from
May 15, 2023
Merged

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented May 12, 2023

Content

This PR includes the implementation of artifact routes for Cardano Immutable Files Full Snapshot and Mithril Stake Distribution signed entity types.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #893

@jpraynaud jpraynaud self-assigned this May 12, 2023
@jpraynaud jpraynaud force-pushed the jpraynaud/893-implement-artifact-routes branch from 2907395 to 1e8c681 Compare May 12, 2023 16:38
@github-actions
Copy link

github-actions bot commented May 12, 2023

Test Results

    3 files  ±0    30 suites  ±0   5m 43s ⏱️ -13s
591 tests +7  591 ✔️ +7  0 💤 ±0  0 ±0 
667 runs  +7  667 ✔️ +7  0 💤 ±0  0 ±0 

Results for commit 9dd318e. ± Comparison against base commit 54e8cf9.

This pull request removes 11 and adds 18 tests. Note that renamed tests count towards both.
http_server::routes::snapshot_routes::tests ‑ test_snapshot_digest_get_ko
http_server::routes::snapshot_routes::tests ‑ test_snapshot_digest_get_ok
http_server::routes::snapshot_routes::tests ‑ test_snapshot_digest_get_ok_nosnapshot
http_server::routes::snapshot_routes::tests ‑ test_snapshot_download_get_ko
http_server::routes::snapshot_routes::tests ‑ test_snapshot_download_get_ok
http_server::routes::snapshot_routes::tests ‑ test_snapshot_download_get_ok_nosnapshot
http_server::routes::snapshot_routes::tests ‑ test_snapshots_get_ko
http_server::routes::snapshot_routes::tests ‑ test_snapshots_get_ok
message_adapters::to_snasphot_message::tests ‑ adapt_ok
snapshot_stores::local_snapshot_store::tests ‑ can_get_added_snapshot_details
…
http_server::routes::artifact_routes::mithril_stake_distribution::tests ‑ test_mithril_stake_distribution_get_ko
http_server::routes::artifact_routes::mithril_stake_distribution::tests ‑ test_mithril_stake_distribution_get_ok
http_server::routes::artifact_routes::mithril_stake_distribution::tests ‑ test_mithril_stake_distribution_ok_norecord
http_server::routes::artifact_routes::mithril_stake_distribution::tests ‑ test_mithril_stake_distributions_get_ko
http_server::routes::artifact_routes::mithril_stake_distribution::tests ‑ test_mithril_stake_distributions_get_ok
http_server::routes::artifact_routes::snapshot::tests ‑ test_snapshot_digest_get_ko
http_server::routes::artifact_routes::snapshot::tests ‑ test_snapshot_digest_get_ok
http_server::routes::artifact_routes::snapshot::tests ‑ test_snapshot_digest_get_ok_nosnapshot
http_server::routes::artifact_routes::snapshot::tests ‑ test_snapshot_download_get_ko
http_server::routes::artifact_routes::snapshot::tests ‑ test_snapshot_download_get_ok
…

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview May 12, 2023 16:47 — with GitHub Actions Inactive
jpraynaud added 3 commits May 15, 2023 12:59
For Cardano Immutable Files Full Snapshot and Mithril Stake Distribution signed entity types.
Implement for Cardano Immutable Files Snapshot and Mithril Stake Distribution.
Adapt artifact builder implementations.
@jpraynaud jpraynaud force-pushed the jpraynaud/893-implement-artifact-routes branch from 1e8c681 to 5608aff Compare May 15, 2023 14:46
@jpraynaud jpraynaud marked this pull request as ready for review May 15, 2023 14:46
@jpraynaud jpraynaud requested review from ghubertpalo and Alenar and removed request for ghubertpalo May 15, 2023 14:46
mithril-common/src/messages/interface.rs Outdated Show resolved Hide resolved
@jpraynaud jpraynaud temporarily deployed to testing-preview May 15, 2023 15:40 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/893-implement-artifact-routes branch from 1e67432 to 1bde5e9 Compare May 15, 2023 15:50
@jpraynaud jpraynaud force-pushed the jpraynaud/893-implement-artifact-routes branch from 1bde5e9 to 46c9152 Compare May 15, 2023 15:59
@jpraynaud jpraynaud temporarily deployed to testing-preview May 15, 2023 16:10 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/893-implement-artifact-routes branch from 46c9152 to 9dd318e Compare May 15, 2023 16:24
@jpraynaud jpraynaud temporarily deployed to testing-preview May 15, 2023 16:33 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 0874697 into main May 15, 2023
@jpraynaud jpraynaud deleted the jpraynaud/893-implement-artifact-routes branch May 15, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt the aggregator REST API to retrieve list/detail of signed entities by signed entity type
2 participants