Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stake distribution computation for zero stake pools #931

Merged
merged 2 commits into from
May 17, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented May 17, 2023

Content

This PR includes a fix on the new stake distribution computation that does not include pools with zero stake.
This will avoid a discrepancy in the AVK computation between legacy and new versions.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #919

@jpraynaud jpraynaud self-assigned this May 17, 2023
@jpraynaud jpraynaud requested a review from ghubertpalo May 17, 2023 08:21
@github-actions
Copy link

Test Results

    3 files  ±0    30 suites  ±0   5m 57s ⏱️ -16s
591 tests ±0  591 ✔️ ±0  0 💤 ±0  0 ±0 
667 runs  ±0  667 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit b5dfb1d. ± Comparison against base commit e064336.

@jpraynaud jpraynaud temporarily deployed to testing-preview May 17, 2023 08:30 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit fc57c6d into main May 17, 2023
@jpraynaud jpraynaud deleted the jpraynaud/919-fix-computation-for-zero-stake-pools branch May 17, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants