Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance terraform infrastructure #957

Merged
merged 7 commits into from
Jun 9, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jun 2, 2023

Content

This PR includes enhancements to the terraform deployment of the Mithril infrastructure:

  • Separate data disk from VM system disk
  • Setup data disk snapshots
  • Clone cardano configurations files in the assets directory of the repository and use them
  • Create a mithril.network.tf recipe that handles network creation in Docker and on which other components depend
  • Make docker logs configurable (json-file or gcplogs)
  • Add an authentication mechanism to possibly keep aggregator private

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #930

@jpraynaud jpraynaud self-assigned this Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Test Results

3 files  ±    0  0 suites   - 30   0s ⏱️ - 5m 41s
0 tests  - 574  0 ✔️  - 574  0 💤 ±0  0 ±0 
0 runs   - 606  0 ✔️  - 606  0 💤 ±0  0 ±0 

Results for commit b2d9441. ± Comparison against base commit 27d5783.

@jpraynaud jpraynaud force-pushed the jpraynaud/930-mithril-infra-enhancements branch 2 times, most recently from efd38b0 to 3d25014 Compare June 6, 2023 16:36
@jpraynaud jpraynaud marked this pull request as ready for review June 6, 2023 16:40
@jpraynaud jpraynaud requested a review from ghubertpalo June 6, 2023 16:40
@jpraynaud jpraynaud temporarily deployed to testing-preview June 7, 2023 07:45 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/930-mithril-infra-enhancements branch from 3d25014 to cd8b1b3 Compare June 7, 2023 07:48
@jpraynaud jpraynaud temporarily deployed to testing-preview June 7, 2023 08:07 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/930-mithril-infra-enhancements branch from cd8b1b3 to 31e9bbc Compare June 8, 2023 12:40
@jpraynaud jpraynaud temporarily deployed to testing-preview June 8, 2023 13:05 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit d29e564 into main Jun 9, 2023
@jpraynaud jpraynaud deleted the jpraynaud/930-mithril-infra-enhancements branch June 9, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance terraform infrastructure
2 participants