Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mithril Client multi-platform test workflow #965

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Fix Mithril Client multi-platform test workflow #965

merged 2 commits into from
Jun 12, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jun 7, 2023 •
edited
Loading

Content

This PR includes a fix in the Mithril Client multi-platform test workflow in order to use the latest client command interface

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #956

@jpraynaud jpraynaud self-assigned this Jun 7, 2023
@jpraynaud jpraynaud requested review from Alenar and ghubertpalo June 7, 2023 15:15
@jpraynaud jpraynaud force-pushed the jpraynaud/956-fix-test-client-workflow branch 2 times, most recently from 18569c7 to ab01c7f Compare June 7, 2023 15:38
@jpraynaud jpraynaud temporarily deployed to testing-preview June 7, 2023 16:02 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/956-fix-test-client-workflow branch from ab01c7f to 1815779 Compare June 8, 2023 14:06
@jpraynaud jpraynaud temporarily deployed to testing-preview June 8, 2023 14:14 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/956-fix-test-client-workflow branch 2 times, most recently from b984e15 to 7859745 Compare June 8, 2023 14:46
@jpraynaud jpraynaud temporarily deployed to testing-preview June 8, 2023 14:53 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/956-fix-test-client-workflow branch from 7859745 to 1a410e1 Compare June 8, 2023 15:25
@jpraynaud jpraynaud temporarily deployed to testing-preview June 8, 2023 15:32 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/956-fix-test-client-workflow branch from 1a410e1 to f01be74 Compare June 8, 2023 15:49
@jpraynaud jpraynaud temporarily deployed to testing-preview June 8, 2023 15:56 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/956-fix-test-client-workflow branch from f01be74 to 51e5ebc Compare June 8, 2023 16:02
@jpraynaud jpraynaud force-pushed the jpraynaud/956-fix-test-client-workflow branch from 51e5ebc to 6688480 Compare June 9, 2023 15:51
@jpraynaud jpraynaud temporarily deployed to testing-preview June 9, 2023 16:02 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/956-fix-test-client-workflow branch 2 times, most recently from 67d6378 to 5fb72bb Compare June 9, 2023 16:28
@jpraynaud jpraynaud force-pushed the jpraynaud/956-fix-test-client-workflow branch from 5fb72bb to ee55416 Compare June 9, 2023 16:36
@jpraynaud jpraynaud temporarily deployed to testing-preview June 9, 2023 16:44 — with GitHub Actions Inactive
@jpraynaud
Fix test client workflow
949ebdc 
Use new client command interface.
@jpraynaud jpraynaud force-pushed the jpraynaud/956-fix-test-client-workflow branch from ee55416 to 949ebdc Compare June 9, 2023 16:47
@jpraynaud jpraynaud temporarily deployed to testing-preview June 9, 2023 16:58 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 8c7ec0d into main Jun 12, 2023
@jpraynaud jpraynaud deleted the jpraynaud/956-fix-test-client-workflow branch June 12, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

@Alenar Alenar Alenar approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Mithril Client multi-platform test with new client interface
3 participants
@jpraynaud @Alenar @ghubertpalo