Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance ImmutableDigesterError::NotEnoughImmutable error #971

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Enhance ImmutableDigesterError::NotEnoughImmutable error #971

merged 2 commits into from
Jun 9, 2023

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jun 8, 2023 •
edited by jpraynaud
Loading

Content

This PR includes an update of the NotEnoughImmutable error message. It now displays the db_dir, expected_number and found_number when not enough immutable files are found in the Cardano node DB directory.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

None

Issue(s)

Close #969

@ghubertpalo ghubertpalo self-assigned this Jun 8, 2023
jpraynaud
jpraynaud requested changes Jun 9, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few modifications to do before it's OK!

mithril-common/src/digesters/immutable_digester.rs Outdated Show resolved Hide resolved
mithril-common/src/digesters/immutable_digester.rs Outdated Show resolved Hide resolved
@dlachaume dlachaume requested a review from jpraynaud June 9, 2023 08:51
jpraynaud
jpraynaud requested changes Jun 9, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we can merge 🙂

  • some typos in the error message need to be fixed
  • you should squash the 2 commits
  • don't forget to update the crates versions
  • the PR description needs to be updated as well (content, comments and checklist)

mithril-common/src/digesters/immutable_digester.rs Outdated Show resolved Hide resolved
@dlachaume dlachaume force-pushed the damien/969-enhance-immutable-digester-error branch from 7ab7656 to e578746 Compare June 9, 2023 09:43
@dlachaume dlachaume requested a review from jpraynaud June 9, 2023 09:43
jpraynaud
jpraynaud approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo merged commit 3550a03 into input-output-hk:main Jun 9, 2023
@dlachaume dlachaume deleted the damien/969-enhance-immutable-digester-error branch July 13, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@ghubertpalo ghubertpalo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance ImmutableDigesterError::NotEnoughImmutable error
3 participants
@dlachaume @jpraynaud @ghubertpalo