-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report _both_ context _and_ info #54
Conversation
0d937c2
to
aa9e6f8
Compare
@coot I am preparing an Unfolder episode on |
Why wrap a tuple in a newtype? Why not make data ThunkInfo = ThunkInfo
{ thunkInfo :: Maybe Info
, thunkContext :: Context
} |
Yup, I'd be happy with that also, just kept the changes to a minimum. Will change that, and fix the failure on 8.10. |
In some cases having both makes debugging a bit easier.
aa9e6f8
to
85e0d22
Compare
Done! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Perfect, thanks so much! I shall be talking about it this Wednesday :) (https://www.youtube.com/watch?v=NTW62s3mrXQ&list=PLD8gywOEY4HaG5VSrKVnHxCptlJv2GAn7) |
#47 changed the
ThunkInfo
type toWhile having support for
Info
is fantastic and a great addition, in some cases having both pieces of information makes debugging a bit easier. I am not entirely sure whyEither
was chosen here instead of a tuple, perhaps there was a good reason; if so, feel free to disregard this PR. However, in this PR we change this to