Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash of partner-chains-node smart-contracts subcommand + small fixes #312

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

LGLO
Copy link
Contributor

@LGLO LGLO commented Dec 10, 2024

Description

Changes from the most to least important ones

  • partner-chains-node smart-contracts <...> was broken because of double logging initialization, we can use both env_logger and log4rs
  • This major bug was not noticed because we added QOL binary in smart-contracts-commands, so I argue having it turned out to be detrimental
  • ogmios-host renamed to ogmios-url, because it more than a host
  • Added return of automatically selected genesis-utxo in run_init_goveranance
  • removed dead code for collateral selection
  • removed dead code for test input creation

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

@LGLO LGLO force-pushed the fix-smart-contracts-commands branch from 4e2accc to e507632 Compare December 10, 2024 10:14
@LGLO LGLO force-pushed the fix-smart-contracts-commands branch from e507632 to 38b835d Compare December 10, 2024 11:03
@LGLO LGLO force-pushed the fix-smart-contracts-commands branch from 38b835d to 4dc0d9f Compare December 10, 2024 11:26
… of dead code, missing return of selected genesis-utxo in init-goveranance
@LGLO LGLO force-pushed the fix-smart-contracts-commands branch from 4dc0d9f to 894bed1 Compare December 10, 2024 14:05
@LGLO LGLO enabled auto-merge (squash) December 10, 2024 14:12
@LGLO LGLO merged commit eaca09d into master Dec 10, 2024
14 checks passed
@LGLO LGLO deleted the fix-smart-contracts-commands branch December 10, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants