Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETCM-9222 generic ExUnit calculation in reserve modules #417

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

kpinter-iohk
Copy link
Contributor

Description

  • Use Cost::calculate_costs in reserve module
  • Remove unused parameters from ReserveRedeemer. These arguments were removed from the Plutus smart contracts a while ago, but the change was not reflected in the purescript code which was reimplemented in rust. The way PlutusData encoding works, superfluous fields can be ignored while decoding, so this didn't cause an issue and went unnoticed.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@kpinter-iohk kpinter-iohk merged commit 2799222 into master Jan 23, 2025
11 checks passed
@kpinter-iohk kpinter-iohk deleted the ETCM-9222-cost-calc-reserve branch January 23, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants