feat: make 'wizards' subcommand of node #419
Draft
+90
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmbientTea
approved these changes
Jan 23, 2025
| @@ -242,7 +229,7 @@ pub fn generate_or_load_key<C: IOContext>( | |||
| &format!("A {} key already exists in store: {key} - overwrite it?", key_def.name), | |||
| false, | |||
| ) { | |||
| let new_key = generate_keys(context, node_executable, key_def)?; | |||
| let new_key = generate_keys(context, &node_executable, key_def)?; | |||
There was a problem hiding this comment.
generate_keys already has access to context, it can get the executable internally
| @@ -59,7 +58,7 @@ pub trait CmdRun { | |||
| fn run<C: IOContext>(&self, context: &C) -> anyhow::Result<()>; | |||
| } | |||
|
|
|||
| fn main() -> anyhow::Result<()> { | |||
| pub fn run(command: Command) -> anyhow::Result<()> { | |||
There was a problem hiding this comment.
How about Command::run? It doesn't have to be from the trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because proper changelog is required for this one and I have to test every flow