Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Stake data source improvements #500

Merged
merged 6 commits into from
Feb 18, 2025

Conversation

AmbientTea
Copy link
Contributor

@AmbientTea AmbientTea commented Feb 17, 2025

Description

  • changes data source method arguments from vectors to slices
  • adds a mock data source
  • wires the data source in the node (unused for now, will be used when the payouts pallet is implemented)
  • fixes a couple of random compilation warnings caused by not using feature flags etc.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@AmbientTea AmbientTea requested review from LGLO and kpinter-iohk and removed request for LGLO February 17, 2025 18:36
@AmbientTea AmbientTea marked this pull request as ready for review February 17, 2025 18:36
@AmbientTea AmbientTea requested a review from LGLO February 17, 2025 18:36
Signed-off-by: Nikolaos Dymitriadis <nikolaos.dymitriadis@iohk.io>
Signed-off-by: Nikolaos Dymitriadis <nikolaos.dymitriadis@iohk.io>
Signed-off-by: Nikolaos Dymitriadis <nikolaos.dymitriadis@iohk.io>
Signed-off-by: Nikolaos Dymitriadis <nikolaos.dymitriadis@iohk.io>
Signed-off-by: Nikolaos Dymitriadis <nikolaos.dymitriadis@iohk.io>
Signed-off-by: Nikolaos Dymitriadis <nikolaos.dymitriadis@iohk.io>
@AmbientTea AmbientTea force-pushed the stake-data-source-improvements branch from 2e76f69 to 4bb9049 Compare February 18, 2025 10:31
@AmbientTea AmbientTea merged commit 1737084 into master Feb 18, 2025
23 checks passed
@AmbientTea AmbientTea deleted the stake-data-source-improvements branch February 18, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants