[DDW-1227] Fix options component dimensions #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriiGaico
requested review from
IuliaDolishniak,
ManusMcCole and
gabriela-ponce
|
@tomothespian i published your last commit with version |
IuliaDolishniak
approved these changes
Mar 13, 2020
|
@DominikGuzei Amazing, thanks alot ❤️ |
ManusMcCole
approved these changes
Mar 13, 2020
gabriela-ponce
approved these changes
Mar 13, 2020
DominikGuzei
added a commit
that referenced
this pull request
Apr 22, 2020
* [DDW-829] Installs react-custom-scrollbars as dependency * [DDW-829] Creates ScrollBar component * [DDW-829] Creates SCROLLBAR identifier * [DDW-829] Creates ScrollBarSkin using react-custom-scrollbars package * [DDW-829] Exports ScrollBarSkin from index using identifier * [DDW-829] Changes render prop to children * [DDW-829] Adds SCROLLBAR_THEME_API * [DDW-829] Adds theme api export * [DDW-829] Creates SimpleScrollBar theme file * [DDW-829] Exports SimpleScrollBar theme file * [DDW-829] Adds configurable CSS vars to theme file * [DDW-829] Swaps className prop for style prop * [DDW-829] Adds ScrollBar story * [DDW-829] Fixes ScrollBar height issue * [DDW-829] Cleans up ScrollBar storybook styles * [DDW-829] Updates CHANGELOG * [DDW-829] Removes root class from ScrollBar's theme * [DDW-829] Adds optionHeight prop to Options component * [DDW-829] Adds optionHeight prop to OptionsSkin and fixes scroll bar height calculation * Add support for *.module.scss file name convention * [DDW-829] Adds big countries list for testing * [DDW-829] Use maintained custom scrollbars package * [DDW-829] Fixes ESLint warning in ScrollBar story * [DDW-829] Arranges ScrollBar scss vars in ABC order * [DDW-829] Makes ScrollBar thumb darker * [DDW-829] Fixes ESLint error in Autocomplete behavior tests * [DDW-829] Fix broken jest snapshots by using enzyme While debugging a testing issue with the new scrollbar component i stumbled over the known problem of „react-test-renderer“ not being able to handle element refs correctly (since it doesn’t involve any real DOM rendering). You can read more about that issue here: facebook/react#7740 This was the root cause and i couldnt make it work with react-test-renderer, so i refactored all the snapshot tests to use enzyme (which supports full DOM rendering). You can see the difference (react-test-renderer outputs a JSON with react component „markup“ whereas enzyme outputs only plain DOM nodes) * [DDW-829] Updates CHANGELOG to include snapshot test refactoring * Prepares CHANGELOG for 0.9.2 release * 0.9.2 * 0.9.2-rc.1 * Fixes prepare-sass-files-for-publishing.js * 0.9.2-rc.2 * [DDW-733] Implement password input component * [DDW-733] Fixes ESLint warning * [DDW-733] Fixes flow error * [DDW-733] Fixes CSS variable names and adds comments to theme file * [DDW-733] Updates CHANGELOG * [DDW-1227] Fix options component dimensions (#135) * [DDW-1227] Introduce a fix for options fixed height * [DDW-1227] Add more optionHeight declarations * [DDW-1227] Fix typo * [DDW-1227] Add GlobalListeners mouse event on root element position * [DDW-1227] Fix flow issues * [DDW-1227] Update CHANGELOG * [DDW-1227] Update stoybook stories due to latest changes * [DDW-1227] CHANGELOG update * Prepare release 0.9.3 (#136) * Prepare release 0.9.3 Co-authored-by: MarcusHurney <marcushurney@gmail.com> Co-authored-by: Danilo Prates <daniloprates@gmail.com> Co-authored-by: Tomislav Horaček <tomislav.horacek@thespian.hr>
nikolaglumac
added a commit
that referenced
this pull request
Jun 25, 2020
* [DDW-829] Installs react-custom-scrollbars as dependency * [DDW-829] Creates ScrollBar component * [DDW-829] Creates SCROLLBAR identifier * [DDW-829] Creates ScrollBarSkin using react-custom-scrollbars package * [DDW-829] Exports ScrollBarSkin from index using identifier * [DDW-829] Changes render prop to children * [DDW-829] Adds SCROLLBAR_THEME_API * [DDW-829] Adds theme api export * [DDW-829] Creates SimpleScrollBar theme file * [DDW-829] Exports SimpleScrollBar theme file * [DDW-829] Adds configurable CSS vars to theme file * [DDW-829] Swaps className prop for style prop * [DDW-829] Adds ScrollBar story * [DDW-829] Fixes ScrollBar height issue * [DDW-829] Cleans up ScrollBar storybook styles * [DDW-829] Updates CHANGELOG * [DDW-829] Removes root class from ScrollBar's theme * [DDW-829] Adds optionHeight prop to Options component * [DDW-829] Adds optionHeight prop to OptionsSkin and fixes scroll bar height calculation * Add support for *.module.scss file name convention * [DDW-829] Adds big countries list for testing * [DDW-829] Use maintained custom scrollbars package * [DDW-829] Fixes ESLint warning in ScrollBar story * [DDW-829] Arranges ScrollBar scss vars in ABC order * [DDW-829] Makes ScrollBar thumb darker * [DDW-829] Fixes ESLint error in Autocomplete behavior tests * [DDW-829] Fix broken jest snapshots by using enzyme While debugging a testing issue with the new scrollbar component i stumbled over the known problem of „react-test-renderer“ not being able to handle element refs correctly (since it doesn’t involve any real DOM rendering). You can read more about that issue here: facebook/react#7740 This was the root cause and i couldnt make it work with react-test-renderer, so i refactored all the snapshot tests to use enzyme (which supports full DOM rendering). You can see the difference (react-test-renderer outputs a JSON with react component „markup“ whereas enzyme outputs only plain DOM nodes) * [DDW-829] Updates CHANGELOG to include snapshot test refactoring * Prepares CHANGELOG for 0.9.2 release * 0.9.2 * 0.9.2-rc.1 * Fixes prepare-sass-files-for-publishing.js * 0.9.2-rc.2 * [DDW-733] Implement password input component * [DDW-733] Fixes ESLint warning * [DDW-733] Fixes flow error * [DDW-733] Fixes CSS variable names and adds comments to theme file * [DDW-733] Updates CHANGELOG * [DDW-1227] Fix options component dimensions (#135) * [DDW-1227] Introduce a fix for options fixed height * [DDW-1227] Add more optionHeight declarations * [DDW-1227] Fix typo * [DDW-1227] Add GlobalListeners mouse event on root element position * [DDW-1227] Fix flow issues * [DDW-1227] Update CHANGELOG * [DDW-1227] Update stoybook stories due to latest changes * [DDW-1227] CHANGELOG update * Prepare release 0.9.3 (#136) * Prepare release 0.9.3 * [DDW-246]: Eliminate usage of deprecated lifecycle methods (#138) * [DDW-246]: Eliminate usage of deprecated lifecycle methods * [DDW-246]: Restore single quote usage * [DDW-246]: Fix props type in tooltip component * [DDW-733] Refactor jest setup (#139) Co-authored-by: Nikola Glumac <niglumac@gmail.com> * [DDW-170] Improved Password input (#140) * [DDW-733] Refactor jest setup * [DDW-733] Implement advanced password input * [DDW-733] Refactor jest setup * [DDW-733] Implement advanced password input * [DDW-733] Center password input asteriks vertically * [DDW-733] Refine indicator and tooltip styles * [DDW-733] Add theme var for tooltip font-family * [DDW-733] Fix tooltip default font-family Co-authored-by: Nikola Glumac <niglumac@gmail.com> * [DDW-170] Improve password repeat feature * [DDW-170] Update changelog * [DDW-170] Prepare changelog for vNext * 0.9.4-rc.1 * [DDW-170] Add className prop to password input * 0.9.4-rc.2 * [DDW-170] Fix tooltip regression on hover * 0.9.4-rc.3 * [DDW-170] Fixes show on focus feature * 0.9.4-rc.4 * [DDW-170] Make tooltip border-radius configurable * 0.9.4-rc.5 * [DDW-170] Remove margin from password input * [DDW-170] Fix custom error logic * 0.9.4-rc.6 * [DDW-170] Fix pw input bg colors * 0.9.4-rc.7 * [DDW-170] Add dedicated flag for password repeats * 0.9.4-rc.8 * [DDW-170] Improve password repeat feature (#141) * [DDW-170] Improve password repeat feature * [DDW-170] Update changelog * [DDW-170] Prepare changelog for vNext * 0.9.4-rc.1 * [DDW-170] Add className prop to password input * 0.9.4-rc.2 * [DDW-170] Fix tooltip regression on hover * 0.9.4-rc.3 * [DDW-170] Fixes show on focus feature * 0.9.4-rc.4 * [DDW-170] Make tooltip border-radius configurable * 0.9.4-rc.5 * [DDW-170] Remove margin from password input * [DDW-170] Fix custom error logic * 0.9.4-rc.6 * [DDW-170] Fix pw input bg colors * 0.9.4-rc.7 * 0.9.4 * Update changelog Co-authored-by: MarcusHurney <marcushurney@gmail.com> Co-authored-by: Danilo Prates <daniloprates@gmail.com> Co-authored-by: Tomislav Horaček <tomislav.horacek@thespian.hr> Co-authored-by: Yakov Karavelov <yakovkaravelov@users.noreply.github.com> Co-authored-by: Nikola Glumac <niglumac@gmail.com>
DominikGuzei
added a commit
that referenced
this pull request
Sep 21, 2020
* [DDW-829] Installs react-custom-scrollbars as dependency * [DDW-829] Creates ScrollBar component * [DDW-829] Creates SCROLLBAR identifier * [DDW-829] Creates ScrollBarSkin using react-custom-scrollbars package * [DDW-829] Exports ScrollBarSkin from index using identifier * [DDW-829] Changes render prop to children * [DDW-829] Adds SCROLLBAR_THEME_API * [DDW-829] Adds theme api export * [DDW-829] Creates SimpleScrollBar theme file * [DDW-829] Exports SimpleScrollBar theme file * [DDW-829] Adds configurable CSS vars to theme file * [DDW-829] Swaps className prop for style prop * [DDW-829] Adds ScrollBar story * [DDW-829] Fixes ScrollBar height issue * [DDW-829] Cleans up ScrollBar storybook styles * [DDW-829] Updates CHANGELOG * [DDW-829] Removes root class from ScrollBar's theme * [DDW-829] Adds optionHeight prop to Options component * [DDW-829] Adds optionHeight prop to OptionsSkin and fixes scroll bar height calculation * Add support for *.module.scss file name convention * [DDW-829] Adds big countries list for testing * [DDW-829] Use maintained custom scrollbars package * [DDW-829] Fixes ESLint warning in ScrollBar story * [DDW-829] Arranges ScrollBar scss vars in ABC order * [DDW-829] Makes ScrollBar thumb darker * [DDW-829] Fixes ESLint error in Autocomplete behavior tests * [DDW-829] Fix broken jest snapshots by using enzyme While debugging a testing issue with the new scrollbar component i stumbled over the known problem of „react-test-renderer“ not being able to handle element refs correctly (since it doesn’t involve any real DOM rendering). You can read more about that issue here: facebook/react#7740 This was the root cause and i couldnt make it work with react-test-renderer, so i refactored all the snapshot tests to use enzyme (which supports full DOM rendering). You can see the difference (react-test-renderer outputs a JSON with react component „markup“ whereas enzyme outputs only plain DOM nodes) * [DDW-829] Updates CHANGELOG to include snapshot test refactoring * Prepares CHANGELOG for 0.9.2 release * 0.9.2 * 0.9.2-rc.1 * Fixes prepare-sass-files-for-publishing.js * 0.9.2-rc.2 * [DDW-733] Implement password input component * [DDW-733] Fixes ESLint warning * [DDW-733] Fixes flow error * [DDW-733] Fixes CSS variable names and adds comments to theme file * [DDW-733] Updates CHANGELOG * [DDW-1227] Fix options component dimensions (#135) * [DDW-1227] Introduce a fix for options fixed height * [DDW-1227] Add more optionHeight declarations * [DDW-1227] Fix typo * [DDW-1227] Add GlobalListeners mouse event on root element position * [DDW-1227] Fix flow issues * [DDW-1227] Update CHANGELOG * [DDW-1227] Update stoybook stories due to latest changes * [DDW-1227] CHANGELOG update * Prepare release 0.9.3 (#136) * Prepare release 0.9.3 * [DDW-246]: Eliminate usage of deprecated lifecycle methods (#138) * [DDW-246]: Eliminate usage of deprecated lifecycle methods * [DDW-246]: Restore single quote usage * [DDW-246]: Fix props type in tooltip component * [DDW-733] Refactor jest setup (#139) Co-authored-by: Nikola Glumac <niglumac@gmail.com> * [DDW-170] Improved Password input (#140) * [DDW-733] Refactor jest setup * [DDW-733] Implement advanced password input * [DDW-733] Refactor jest setup * [DDW-733] Implement advanced password input * [DDW-733] Center password input asteriks vertically * [DDW-733] Refine indicator and tooltip styles * [DDW-733] Add theme var for tooltip font-family * [DDW-733] Fix tooltip default font-family Co-authored-by: Nikola Glumac <niglumac@gmail.com> * [DDW-170] Improve password repeat feature * [DDW-170] Update changelog * [DDW-170] Prepare changelog for vNext * 0.9.4-rc.1 * [DDW-170] Add className prop to password input * 0.9.4-rc.2 * [DDW-170] Fix tooltip regression on hover * 0.9.4-rc.3 * [DDW-170] Fixes show on focus feature * 0.9.4-rc.4 * [DDW-170] Make tooltip border-radius configurable * 0.9.4-rc.5 * [DDW-170] Remove margin from password input * [DDW-170] Fix custom error logic * 0.9.4-rc.6 * [DDW-170] Fix pw input bg colors * 0.9.4-rc.7 * [DDW-170] Add dedicated flag for password repeats * 0.9.4-rc.8 * [DDW-170] Improve password repeat feature (#141) * [DDW-170] Improve password repeat feature * [DDW-170] Update changelog * [DDW-170] Prepare changelog for vNext * 0.9.4-rc.1 * [DDW-170] Add className prop to password input * 0.9.4-rc.2 * [DDW-170] Fix tooltip regression on hover * 0.9.4-rc.3 * [DDW-170] Fixes show on focus feature * 0.9.4-rc.4 * [DDW-170] Make tooltip border-radius configurable * 0.9.4-rc.5 * [DDW-170] Remove margin from password input * [DDW-170] Fix custom error logic * 0.9.4-rc.6 * [DDW-170] Fix pw input bg colors * 0.9.4-rc.7 * Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> * Bump elliptic from 6.4.0 to 6.5.3 (#144) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.4.0 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.4.0...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [issue-145] Remove deprecated postinstall-build package (#146) * [issue-145] Remove deprecated postinstall-build package * [issue-145] Update changelog * 0.9.5-rc.1 * Bump lodash.merge from 4.6.1 to 4.6.2 (#148) Bumps [lodash.merge](https://github.com/lodash/lodash) from 4.6.1 to 4.6.2. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump node-sass from 4.13.0 to 4.13.1 (#147) Bumps [node-sass](https://github.com/sass/node-sass) from 4.13.0 to 4.13.1. - [Release notes](https://github.com/sass/node-sass/releases) - [Changelog](https://github.com/sass/node-sass/blob/master/CHANGELOG.md) - [Commits](sass/node-sass@v4.13.0...v4.13.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dominik Guzei <dominik.guzei@gmail.com> * 0.9.5 Co-authored-by: MarcusHurney <marcushurney@gmail.com> Co-authored-by: Danilo Prates <daniloprates@gmail.com> Co-authored-by: Tomislav Horaček <tomislav.horacek@thespian.hr> Co-authored-by: Yakov Karavelov <yakovkaravelov@users.noreply.github.com> Co-authored-by: Nikola Glumac <niglumac@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces flexible option height and availability to pass them from parent components.
Testing Checklist
AutocompletesectionSelectsectionOptionssectionDropdownsection