Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETCM-168: ETC testnet fixes #100

Merged
merged 7 commits into from
Nov 4, 2020
Merged

ETCM-168: ETC testnet fixes #100

merged 7 commits into from
Nov 4, 2020

Conversation

aakoshh
Copy link
Contributor

@aakoshh aakoshh commented Nov 3, 2020 •
edited
Loading

Fixes necessary for connecting to the ETC testnet:

  • expiration was supposed to be seconds, not millis, since epoch
  • implement Ping hash workaround for Parity nodes
  • ports in the ENR should be treated as unsigned its, otherwise they may be interpreted as negative values because other clients send shorter, 2 byte values

@aakoshh aakoshh marked this pull request as ready for review November 3, 2020 14:04
@aakoshh aakoshh requested a review from KonradStaniec November 3, 2020 14:05
@aakoshh aakoshh mentioned this pull request Nov 3, 2020
Merged
@aakoshh aakoshh requested a review from ntallar November 3, 2020 17:51
@aakoshh aakoshh merged commit 7672926 into develop Nov 4, 2020
@aakoshh aakoshh deleted the ETCM-168-discovery-part4 branch November 4, 2020 15:05
@aakoshh aakoshh mentioned this pull request Nov 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonradStaniec KonradStaniec KonradStaniec approved these changes

@ntallar ntallar Awaiting requested review from ntallar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aakoshh @KonradStaniec