Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

[CAD-2181] All queries that don't return anything should return 404 #117

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

ksaric
Copy link
Contributor

@ksaric ksaric commented Nov 10, 2020

https://jira.iohk.io/browse/CAD-736

Also fixed the failing tests.

@ksaric
Copy link
Contributor Author

ksaric commented Nov 10, 2020

bors try

iohk-bors bot added a commit that referenced this pull request Nov 10, 2020
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 10, 2020

try

Build succeeded:

@ksaric ksaric merged commit 829e180 into master Nov 10, 2020
@iohk-bors iohk-bors bot deleted the ksaric/CAD-2181 branch November 10, 2020 09:28
This was referenced Dec 10, 2020
@ArturWieczorek
Copy link

Looks good to me.

curl --verbose --header "Content-Type: application/json" --request GET http://localhost:3100/api/v1/i_dont_exist
Note: Unnecessary use of -X or --request, GET is already inferred.

  • Trying 127.0.0.1...
  • TCP_NODELAY set
  • Connected to localhost (127.0.0.1) port 3100 (#0)

GET /api/v1/i_dont_exist HTTP/1.1
Host: localhost:3100
User-Agent: curl/7.58.0
Accept: /
Content-Type: application/json

< HTTP/1.1 404 Not Found
< Transfer-Encoding: chunked
< Date: Mon, 14 Dec 2020 14:21:50 GMT
< Server: Warp/3.3.13
<

  • Connection #0 to host localhost left intact

curl --verbose --header "Content-Type: application/json" --request GET http://localhost:3100/api/v2/delist
Note: Unnecessary use of -X or --request, GET is already inferred.

  • Trying 127.0.0.1...
  • TCP_NODELAY set
  • Connected to localhost (127.0.0.1) port 3100 (#0)

GET /api/v2/delist HTTP/1.1
Host: localhost:3100
User-Agent: curl/7.58.0
Accept: /
Content-Type: application/json

< HTTP/1.1 404 Not Found
< Transfer-Encoding: chunked
< Date: Mon, 14 Dec 2020 14:22:04 GMT
< Server: Warp/3.3.13
<

  • Connection #0 to host localhost left intact

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants