This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
[CAD-2178] The retryCount from the /errors endpoint is not correctly incremented. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksaric
force-pushed
the
ksaric/CAD-2178
branch
2 times, most recently
from
5c91496 to
da43777
Compare
|
bors try |
|
Please note that it is possible that a user submits the same pool hash several times which will result in the fetch being done for each of the entries initially. We do this in order to make sure that the metadata wasn't fixed in the meantime, but after the initial fetch, we keep retrying just the latest fetch error (since the errors persisted, that means that not a single entry fixed all the issues). |
tryBuild failed: |
ksaric
force-pushed
the
ksaric/CAD-2178
branch
from
da43777 to
ff2989d
Compare
|
bors try |
tryBuild succeeded: |
|
Also tested with the previous version syncing up to (less then tip) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.iohk.io/browse/CAD-2178