Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JCL-317: Deprecate use of stream in return types #400

Merged
merged 2 commits into from
Apr 5, 2023
Merged

JCL-317: Deprecate use of stream in return types #400

merged 2 commits into from
Apr 5, 2023

Conversation

acoburn
Copy link
Collaborator

@acoburn acoburn commented Apr 4, 2023

This deprecates the SolidContainer::getContainedResources method and adds a new SolidContainer::getResources method.

The deprecated method returns a Stream, while the new one returns an immutable Set. This will make it easier to work with in Kotlin-based systems.

@acoburn acoburn requested a review from a team as a code owner April 4, 2023 19:06
@acoburn acoburn temporarily deployed to ESS PodSpaces April 4, 2023 19:06 — with GitHub Actions Inactive
@acoburn acoburn temporarily deployed to ESS PodSpaces April 4, 2023 19:06 — with GitHub Actions Inactive
@acoburn acoburn temporarily deployed to ESS DevNext April 4, 2023 19:06 — with GitHub Actions Inactive
timea-solid
timea-solid approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@timea-solid timea-solid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the examples & archetype already now?

@acoburn acoburn temporarily deployed to ESS PodSpaces April 5, 2023 12:41 — with GitHub Actions Inactive
@acoburn acoburn temporarily deployed to ESS PodSpaces April 5, 2023 12:41 — with GitHub Actions Inactive
@acoburn acoburn temporarily deployed to ESS DevNext April 5, 2023 12:41 — with GitHub Actions Inactive
@acoburn acoburn merged commit 6acfe3a into main Apr 5, 2023
@acoburn acoburn deleted the JCL-317-return-types branch April 5, 2023 13:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timea-solid timea-solid timea-solid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acoburn @timea-solid