Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JCL-341: Omit Accept Turtle header when reading non-RDF resources #445

Merged
merged 1 commit into from
May 9, 2023
Merged

JCL-341: Omit Accept Turtle header when reading non-RDF resources #445

merged 1 commit into from
May 9, 2023

Conversation

acoburn
Copy link
Collaborator

@acoburn acoburn commented May 8, 2023

At present, the SolidClient::read sends an Accept: text/turtle header for all requests. This is incorrect for non-RDF resources, which may respond with a 406 Not Acceptable to such requests.

@acoburn acoburn requested a review from a team as a code owner May 8, 2023 20:08
@acoburn acoburn temporarily deployed to ESS PodSpaces May 8, 2023 20:08 — with GitHub Actions Inactive
@acoburn acoburn temporarily deployed to ESS PodSpaces May 8, 2023 20:08 — with GitHub Actions Inactive
@acoburn acoburn temporarily deployed to ESS DevNext May 8, 2023 20:08 — with GitHub Actions Inactive
@timea-solid timea-solid merged commit 321dac4 into main May 9, 2023
@timea-solid timea-solid deleted the JCL-341-read-non-rdfsource branch May 9, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timea-solid timea-solid timea-solid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acoburn @timea-solid