Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCL-335: Rework API and type hierarchy in accessgrant module #461

Merged
merged 3 commits into from
May 19, 2023

Conversation

acoburn
Copy link
Collaborator

@acoburn acoburn commented May 19, 2023

Supersedes #422, integrating the code in that PR into an implementation that does not break backwards compatibility and which does not leak VC implementation details.

This introduces a simple type hierarchy for the access grant module:

interface AccessCredential {}
class AccessGrant implements AccessCredential {}
class AccessRequest implements AccessCredential {}

And using that hierarchy, we have a clearer API:

CompletionStage<AccessGrant> grant = client.requestAccess(...).thenCompose(client::grantAccess);

Some of the existing APIs have been deprecated in favor of methods that make use of this hierarchy.

@acoburn acoburn requested a review from a team as a code owner May 19, 2023 01:04
@acoburn acoburn merged commit ff9d6bc into main May 19, 2023
@acoburn acoburn deleted the JCL-335-accessgrant-type-hierarchy branch May 19, 2023 12:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants