Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use @types/node buffer type rather than lib.dom.ts #1979

Merged
merged 19 commits into from
May 10, 2023
Merged

fix: use @types/node buffer type rather than lib.dom.ts #1979

merged 19 commits into from
May 10, 2023

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented May 8, 2023 •
edited
Loading

This PR fixes #.

As discussed in microsoft/TypeScript#53668
the @types/node definition of a buffer is looser and hence we should
use that in order to be compaible with web buffer types and node
buffer types

  • I've added a unit test to test for potential regressions of this bug.
  • The changelog has been updated, if applicable.
  • Commits in this PR are minimal and have descriptive commit messages.

@jeswr
fix: use @types/node buffer type rather than lib.dom.ts
5d444e0 
As discussed in microsoft/TypeScript#53668
the @types/node definition of a buffer is looser and hence we should
use that in order to be compaible with web buffer types and node
buffer types
@vercel
Copy link

vercel bot commented May 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solid-client-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 8:40am

@jeswr jeswr temporarily deployed to NSS May 8, 2023 15:59 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 8, 2023 15:59 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 8, 2023 15:59 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 8, 2023 16:01 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 8, 2023 16:01 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 8, 2023 16:01 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 8, 2023 16:01 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS Dev-Next May 8, 2023 16:01 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 8, 2023 16:10 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 10, 2023 08:39 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 10, 2023 08:39 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 10, 2023 08:39 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 10, 2023 08:39 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 10, 2023 08:39 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 10, 2023 08:39 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 10, 2023 08:39 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS Dev-Next May 10, 2023 08:39 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 10, 2023 09:12 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 10, 2023 09:12 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 10, 2023 09:12 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 10, 2023 09:12 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 10, 2023 09:12 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 10, 2023 09:12 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 10, 2023 09:12 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 10, 2023 09:12 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 10, 2023 09:27 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 10, 2023 09:27 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 10, 2023 09:27 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 10, 2023 09:27 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 10, 2023 09:27 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 10, 2023 09:27 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS PodSpaces May 10, 2023 09:27 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to NSS May 10, 2023 09:27 — with GitHub Actions Inactive
@jeswr jeswr temporarily deployed to ESS Dev-Next May 10, 2023 09:27 — with GitHub Actions Inactive
@jeswr jeswr merged commit dabf1a1 into main May 10, 2023
@jeswr jeswr deleted the fix/use-node-buffer-type branch May 10, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NSeydoux NSeydoux NSeydoux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeswr @NSeydoux