CreateEventFromVOBJ: if there is no dtend, use the duration if available #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarnett
commented
Sep 25, 2024
| @@ -64,65 +64,54 @@ def CreateEventFromVOBJ( | |||
|
|
|||
| event['recurrence'] = ['RRULE:' + ve.rrule.value] | |||
|
|
|||
| if hasattr(ve, 'dtstart') and ve.dtstart.value: | |||
There was a problem hiding this comment.
Combined this check w/ the one above and dedented this huge if block.
Technically if an event had .dtstart but not .dtstart.value this change might skip that event more explicitly, but I'm pretty sure that scenario was never valid and nobody was relying on that corner case behavior.
dbarnett
commented
Sep 25, 2024
gcalcli/ics.py
Outdated
Comment on lines
116
to
117
| # Decide based on dtstart; that's what we base our calculation on. | ||
| # TODO: correct? |
There was a problem hiding this comment.
I had a look at this TODO and it looked pretty obvious that yes duration is always counting from dtstart. Removed the TODO comment.
|
Alright @tschwinge @jcrowgey I'm happy with my updated version of these changes. LMK if either of you wants to take a look before I merge them. |
dbarnett
force-pushed
the
dtend-duration
branch
from
18cd990
to
3cb3224
Compare
dbarnett
force-pushed
the
dtend-duration
branch
from
3cb3224
to
a4d5a23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #486.
Credit: Changes taken from #282 and rebased onto main, with trivial cleanups and a tweak to the dtstart-only case (30m duration + info message instead of 0m duration).