Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run fix_typos.sh on repo to catch spelling errors #1082

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

scottstanie
Copy link
Contributor

@scottstanie scottstanie commented Aug 29, 2023

Description of proposed changes

I saw that GDAL had an interactive script to catch typos on their entire repo. I copied this over to the scripts/ directory and tried to make the changes that I saw which were definitely typos and not deliberate choices.

Please feel free to change back any of them which you think were incorrectly modified.

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@yunjunz yunjunz self-requested a review August 30, 2023 01:14
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool!! Thank you @scottstanie! It's great to see SO many typos got caught and fixed.

I added a few sentences on the wiki on the usage of this, following on the note on gdal, but have don't succeeded on running it due to some internet connection issue. Please feel free to update the wiki page for it as well.

@yunjunz yunjunz merged commit 7ff149b into insarlab:main Aug 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants