Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view --dem-blend: support data/DEM in diff resolutions #1102

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Oct 6, 2023

Description of proposed changes

This PR supports input data and DEM files in different resolution for view --dem-blend (#1089), by resampling the lower resolution one into higher resolution on the fly using skimage.transform.resize()

  • utils.plot.prep_blend_image(): add resampling on the fly using skimage.transform.resize() to support different resolutions between data and DEM while using the view.py --dem-blend option

  • utils.plot.prep_blend_image(): change the default base_color from 0.9 to 0.7, for a slightly darker DEM background

  • cli.view.cmd_line_parse(): ignore --cbar-ext option if --dem-blend is specified as well.

  • .github/ISSUE_TEMPLATE/bug_report.md: add insar processor/product info

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

…e fly

+ utils.plot.prep_blend_image(): add resampling on the fly using skimage.transform.resize() to support different resolutions between data and DEM while using the view.py --dem-blend option

+ utils.plot.prep_blend_image(): change the default base_color from 0.9 to 0.7, for a slightly darker DEM background

+ cli.view.cmd_line_parse(): ignore --cbar-ext option if --dem-blend is specified as well.

+ .github/ISSUE_TEMPLATE/bug_report.md: add insar processor/product info
@yunjunz yunjunz requested a review from yuankailiu October 6, 2023 06:54
@yunjunz yunjunz changed the title view --dem-blend: support data/DEM in diff reso by resampling on th… view --dem-blend: support data/DEM in diff resolutions Oct 6, 2023
Copy link
Contributor

@yuankailiu yuankailiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yunjunz, this is great.

@yuankailiu yuankailiu merged commit cd1cae9 into insarlab:main Oct 6, 2023
4 checks passed
@yunjunz yunjunz deleted the dem-blend-resampling branch October 7, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants