Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save_kmz: support data in UTM #1210

Merged
merged 6 commits into from
Jun 6, 2024
Merged

save_kmz: support data in UTM #1210

merged 6 commits into from
Jun 6, 2024

Conversation

Alex-Lewandowski
Copy link
Contributor

@Alex-Lewandowski Alex-Lewandowski commented May 31, 2024

Description of proposed changes

This addresses an issue causing improperly geocoded velocity kmz files from data in UTM. KML only natively supports WGS84, so I added code to convert the bounding box coordinates to WGS84 when necessary.

Reminders

  • Fix Output KMZs not properly geocoded for time series in UTM #1211
  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

Copy link

welcome bot commented May 31, 2024

💖 Thanks for opening this pull request! Please check out our contributing guidelines. 💖
Keep in mind that all new features should be documented. It helps to write the comments next to the code or below your functions describing all arguments, and return types before writing the code. This will help you think about your code design and usually results in better code.

Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @Alex-Lewandowski!

@yunjunz yunjunz changed the title Add support to save_kmz.py for data in UTM save_kmz: support data in UTM Jun 6, 2024
@yunjunz yunjunz merged commit 44d5afd into main Jun 6, 2024
7 of 8 checks passed
Copy link

welcome bot commented Jun 6, 2024

🎉 🎉 🎉 Congrats on merging your first pull request! We here at behaviorbot are proud of you! 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output KMZs not properly geocoded for time series in UTM
2 participants