Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for block-by-block resample & run/skip in load_data #888

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Nov 4, 2022

Description of proposed changes

  • objects.resample.prepare_geometry_definition_radar(): use abs() to ensure positive area calculation for both source/destination, before the adaptive source bbox calculation for block-by-block processing.

  • load_data.run_or_skip: check length/width only for ifgramStack to be able to skip re-loading if the existing ifgramStack file has more pairs than the input.

  • smallbaselineApp --plot: use relpath() for ionStack.h5 file

Reminders

  • Pass Codacy code review (green)
  • Pass Pre-commit check (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.

+ objects.resample.prepare_geometry_definition_radar(): use abs() to ensure positive area calculation for both source/destination, before the adaptive source bbox calculation for block-by-block processing.

+ load_data.run_or_skip: check length/width only for ifgramStack to be able to skip re-loading if existing ifgramStack file has more pairs than the input.

+ smallbaselineApp --plot: use relpath() for ionStack.h5 file
@yunjunz yunjunz merged commit ffefb7c into insarlab:main Nov 4, 2022
@yunjunz yunjunz deleted the bugfix branch November 4, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant