Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save_gbis: support non-velocity dataset from the velocity file #916

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

bjmarfito
Copy link
Contributor

@bjmarfito bjmarfito commented Nov 24, 2022

Description of proposed changes

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yunjunz yunjunz merged commit 89fc646 into main Nov 24, 2022
@yunjunz yunjunz deleted the bjmarfito-patch-1 branch November 24, 2022 23:33
@bjmarfito
Copy link
Contributor Author

Thank you @yunjunz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants