-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New images for CRAN emulations #65
Conversation
These images will eventually feed into pharmaverse/admiralci#35 or similar workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Dinakar <26552821+cicdguy@users.noreply.github.com>
If I'm reading this right it looks like you are using the rhub images as your backbone. I just wanted to say that our big issue was that the rhub images don't really track the CRAN machines that well particularly the fedora machines. In particular CRAN is using fedora 36 + clang 15 whilst rhub is using fedora33 + clang 11. This meant we were getting issues on CRAN that we weren't able to reproduce on rHub. I posted an issue about this here: |
Aw shucks. Ok looks like we need to wait till those images are updated then. |
Thus was the basis for my request if we could develop our own internal images that more closely aligned with CRAN's. Even if it was only just for some of the more problematic ones like their fedora and debian machines. |
We can look into updating RHub's images for them instead of maintaining our own, that way other users will also benefit from those enhancements. |
Makes sense to me :) |
Adds Debian and Fedora images which will be used for CRAN emulations. Signed-off-by: Dinakar <26552821+cicdguy@users.noreply.github.com>
Adds Debian and Fedora images which will be used for CRAN emulations. Signed-off-by: Dinakar <26552821+cicdguy@users.noreply.github.com>
Adds Debian and Fedora images which will be used for CRAN emulations. Signed-off-by: Dinakar <26552821+cicdguy@users.noreply.github.com>
Adds Debian and Fedora images which will be used for CRAN emulations. Signed-off-by: Dinakar <26552821+cicdguy@users.noreply.github.com>
Adds Debian and Fedora images which will be used for CRAN emulations. Signed-off-by: Dinakar <26552821+cicdguy@users.noreply.github.com>
Adds Debian and Fedora images which will be used for CRAN emulations. Signed-off-by: Dinakar <26552821+cicdguy@users.noreply.github.com>
Adds Debian and Fedora images which will be used for CRAN emulations. Signed-off-by: Dinakar <26552821+cicdguy@users.noreply.github.com>
Adds Debian and Fedora images which will be used for CRAN emulations. Signed-off-by: Dinakar <26552821+cicdguy@users.noreply.github.com>
Adds Debian and Fedora images which will be used for CRAN emulations. Signed-off-by: Dinakar <26552821+cicdguy@users.noreply.github.com>
Adds Debian and Fedora images which will be used for CRAN emulations. Signed-off-by: Dinakar <26552821+cicdguy@users.noreply.github.com>
Adds Debian and Fedora images which will be used for CRAN emulations. Signed-off-by: Dinakar <26552821+cicdguy@users.noreply.github.com>
Adds Debian and Fedora images which will be used for CRAN emulations.