Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for binary dependencies #9

Merged
merged 10 commits into from
Nov 14, 2023
Merged

Add support for binary dependencies #9

merged 10 commits into from
Nov 14, 2023

Conversation

walkowif
Copy link
Contributor

@walkowif walkowif commented Nov 13, 2023 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2023 •
edited
Loading

Unit Tests Summary

8 tests   8 ✔️  0s ⏱️
2 suites  0 💤
1 files    0 ❌

Results for commit 0309db1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename            Stmts    Miss  Cover    Missing
----------------  -------  ------  -------  ---------------------------------------------------------------------------
cmd/construct.go      161      14  91.30%   53-55, 116-120, 152-154, 238-240
cmd/download.go       173      51  70.52%   50-70, 89-91, 108-110, 137-139, 155-157, 177-179, 220-228, 241-245, 252-254
cmd/parse.go          103      12  88.35%   36-42, 50-51, 59-61
cmd/renv.go            26       0  100.00%
cmd/root.go           126     123  2.38%    48-129, 136-189
cmd/utils.go           71      31  56.34%   27-29, 51-62, 70-72, 80-82, 87-89, 110-116
TOTAL                 660     231  65.00%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  -------
cmd/download.go       +9      +5  -1.43%
cmd/parse.go          +1      +1  -0.87%
TOTAL                +10      +6  -0.38%

Results for commit: 0309db1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@walkowif walkowif marked this pull request as ready for review November 14, 2023 15:59
@walkowif walkowif requested a review from a team as a code owner November 14, 2023 15:59
cicdguy
cicdguy approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walkowif walkowif merged commit e2dce76 into main Nov 14, 2023
9 checks passed
@walkowif walkowif deleted the add-support-for-binary-dependencies branch November 14, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdguy cicdguy cicdguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@walkowif @cicdguy