Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing vbump for tern #619

Merged
merged 2 commits into from
May 3, 2023
Merged

fixing vbump for tern #619

merged 2 commits into from
May 3, 2023

Conversation

Melkiades
Copy link
Contributor

fixes #618

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Unit Tests Summary

    1 files    19 suites   1m 12s ⏱️
165 tests 165 ✔️ 0 💤 0
678 runs  678 ✔️ 0 💤 0

Results for commit 9a6f0a3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

badge

Code Coverage Summary

Filename                  Stmts    Miss  Cover    Missing
----------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/00tabletrees.R            624      41  93.43%   74, 76, 345, 420-421, 424, 561, 652, 733-734, 824, 826-827, 849-850, 870, 1047-1050, 1180, 1264-1265, 1323-1326, 1359-1360, 1366-1371, 1414, 1420, 1509, 1601, 1611, 1639, 1664-1665
R/as_html.R                  88       7  92.05%   7-12, 68
R/colby_constructors.R      490      17  96.53%   63, 106-107, 155-156, 202-203, 328, 339, 1061, 1136, 1279, 1315, 1334, 1354, 1371, 1515
R/compare_rtables.R          78      11  85.90%   95-96, 99-100, 113-114, 131, 150-151, 181, 185
R/format_rcell.R             12       0  100.00%
R/indent.R                   13       2  84.62%   39-40
R/index_footnotes.R          50       0  100.00%
R/make_split_fun.R           97      15  84.54%   22-25, 48-49, 51-52, 103, 106, 252, 254-255, 259-260, 276, 366
R/make_subset_expr.R        106      12  88.68%   26-35, 93-98, 131, 197, 208, 215
R/simple_analysis.R           5       1  80.00%   48
R/split_funs.R              421      54  87.17%   131, 135, 140-145, 149, 159-161, 195-196, 319-322, 338-343, 413, 453, 467-468, 482, 538, 547-548, 550, 562, 604, 624, 778, 785, 810-811, 819-820, 822-823, 981-982, 993-996, 1059-1060, 1116-1117
R/summary.R                 186      19  89.78%   83, 187, 194, 259-262, 272-273, 292-293, 398, 452-456, 484, 512
R/tree_accessors.R          793      68  91.42%   93, 210, 223, 240, 271, 281, 293, 385, 407-408, 662-666, 774, 788, 805, 846, 900-901, 959, 991-995, 1042, 1104-1106, 1120, 1186, 1272-1273, 1291, 1305-1306, 1357-1360, 1378-1381, 1445, 1483, 1573, 1651, 1661, 1671, 1680, 1686, 1692-1695, 1973, 2250, 2344, 2554, 2653, 2676-2704, 2716-2721
R/tt_afun_utils.R           345      25  92.75%   44, 146, 152, 160-169, 218, 229-230, 452, 459-460, 524-526, 545, 559-560
R/tt_compare_tables.R        65       4  93.85%   56, 170, 248, 251
R/tt_compatibility.R        413      50  87.89%   19, 137-138, 187, 191, 321-322, 325-328, 335, 338, 365, 371-372, 442, 484, 513, 531, 555-556, 596, 609-611, 680, 705-708, 717, 769, 775, 782-783, 887, 893, 919-931, 960-961
R/tt_dotabulation.R         740      44  94.05%   36, 202, 204, 247, 268, 271-272, 318, 350-351, 372, 379-380, 460, 582-584, 633, 636, 665, 852, 855, 882, 993-994, 1110-1114, 1149-1153, 1250, 1343-1351
R/tt_export.R               229      35  84.72%   47, 63, 105-118, 176-177, 203, 267-268, 274, 315-321, 325-327, 423-424, 436, 548, 580
R/tt_from_df.R                9       0  100.00%
R/tt_paginate.R             377       9  97.61%   69, 355, 667-672, 749, 752
R/tt_pos_and_access.R       520      37  92.88%   73, 75-76, 100, 152, 187-189, 234, 473, 475, 482, 488, 501, 510-511, 673, 684-686, 692-695, 723, 765-766, 776, 928-929, 978-1002, 1221, 1289
R/tt_showmethods.R          121      20  83.47%   47, 73-87, 138, 154-157, 163, 170, 172-174, 252-253
R/tt_sort.R                  76       3  96.05%   211-212, 218
R/tt_toString.R             312      22  92.95%   112, 308, 317, 332, 339, 468, 522, 528, 567-570, 737-762
R/utils.R                    15       1  93.33%   109
R/Viewer.R                   56       9  83.93%   51, 55, 65-68, 87-88, 118
TOTAL                      6241     506  91.89%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  -------
R/colby_constructors.R       +8       0  +0.06%
R/make_split_fun.R          +97     +15  +84.54%
R/split_funs.R                0      -1  +0.24%
R/summary.R                  +3      +3  -1.47%
R/tt_dotabulation.R          +3       0  +0.02%
R/tt_export.R                 0     -38  +16.59%
R/tt_paginate.R              -6      -6  +1.53%
R/tt_showmethods.R            0      -1  +0.83%
R/tt_sort.R                  -5      -3  +3.46%
R/tt_toString.R              +7       0  +0.16%
R/utils.R                    +4       0  +2.42%
TOTAL                      +111     -31  +0.65%

Results for commit: a4b63c2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@Melkiades Melkiades merged commit fcd85bb into main May 3, 2023
@Melkiades Melkiades deleted the 618_vbumpfix@main branch May 3, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vbump to fix error in tern
2 participants