Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedback from future devs #106

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Add feedback from future devs #106

merged 3 commits into from
Jan 11, 2024

Conversation

holgstr
Copy link
Contributor

@holgstr holgstr commented Dec 27, 2023

Fixes #105

Copy link
Contributor

github-actions bot commented Dec 27, 2023

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------
R/assertions.R                  15       0  100.00%
R/corPFSOS.R                    96      20  79.17%   317-336
R/empSignificant.R              59       0  100.00%
R/estimateParams.R              80       0  100.00%
R/eventTracking.R               88       2  97.73%   48, 244
R/getClinicalTrials.R           71       0  100.00%
R/getSimulatedData.R           109       0  100.00%
R/getWaitTimeSum.R              29       2  93.10%   45, 48
R/hazardFunctions.R             26       0  100.00%
R/piecewiseDistribution.R       32       0  100.00%
R/piecewiseHazards.R            18       0  100.00%
R/survivalFunctions.R          157       0  100.00%
R/transitionParameters.R        42       0  100.00%
TOTAL                          822      24  97.08%

Diff against main

Filename        Stmts    Miss  Cover
------------  -------  ------  -------
R/corPFSOS.R       +1      +1  -0.83%
TOTAL              +1      +1  -0.12%

Results for commit: fab5202

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Dec 27, 2023

Unit Tests Summary

  1 files   16 suites   2m 14s ⏱️
104 tests 103 ✅ 1 💤 0 ❌
230 runs  229 ✅ 1 💤 0 ❌

Results for commit fab5202.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @holgstr - is it worth a bug fix NEWS entry?

@holgstr
Copy link
Contributor Author

holgstr commented Jan 10, 2024

@danielinteractive yes :)

Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
getSimulatedDataDistib 💔 $96.47$ $+2.81$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
getSimulatedDataDistib 💔 $34.39$ $+1.47$ getSimulatedData_generates_distributions_as_expected_PW
getSimulatedDataDistib 💔 $50.53$ $+1.25$ getSimulatedData_generates_distributions_as_expected_Weibull

Results for commit 0935406

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @holgstr , one minor detail and then good to merge

NEWS.md Outdated Show resolved Hide resolved
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com>
Signed-off-by: Holger Löwe <64039523+holgstr@users.noreply.github.com>
@holgstr holgstr merged commit 43dc43a into main Jan 11, 2024
2 of 3 checks passed
@holgstr holgstr deleted the issue105-future branch January 11, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please undo your future::plan() when function exits
2 participants