-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feedback from future devs #106
Conversation
Code Coverage Summary
Diff against main
Results for commit: fab5202 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 16 suites 2m 14s ⏱️ Results for commit fab5202. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @holgstr - is it worth a bug fix NEWS entry?
@danielinteractive yes :) |
Unit Test Performance Difference
Additional test case details
Results for commit 0935406 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @holgstr , one minor detail and then good to merge
Co-authored-by: Daniel Sabanes Bove <danielinteractive@users.noreply.github.com> Signed-off-by: Holger Löwe <64039523+holgstr@users.noreply.github.com>
Fixes #105