-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds ExpHazOS function #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @holgstr ! Nice first PR - please see few comments below. In addition please add this function to the pkgdown
yaml file
Code Coverage Summary
Diff against main
Results for commit: e84dcd8 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Oh and we need unit tests |
Hey @danielinteractive, should have included all of your feedback except the comment regarding the pkgdown yaml. Is there an automatic function call to do this efficiently just for one function added to the package? |
You can just edit the https://github.com/insightsengineering/simIDM/blob/main/_pkgdown.yaml file manually as part of this PR. There is no more automatic way to do that (AFAIK) |
_pkgdown.yaml is updated now |
so now as soon as all checks are green (passed) then you can hit the Squash and Merge button |
@danielinteractive cool, thanks! :) |
Pull Request
adds ExpHazOS function