Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

66: Add Function to compute average Hazard Ratio OS #67

Merged
merged 7 commits into from
Sep 21, 2023
Merged

Conversation

holgstr
Copy link
Contributor

@holgstr holgstr commented Sep 20, 2023

Fixes #66

@holgstr holgstr added the enhancement New feature or request label Sep 20, 2023
@holgstr holgstr self-assigned this Sep 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Unit Tests Summary

    1 files    13 suites   2m 54s ⏱️
  54 tests   54 ✔️ 0 💤 0
133 runs  133 ✔️ 0 💤 0

Results for commit 2bd66f4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------
R/assertions.R                  15       0  100.00%
R/eventTracking.R               88       2  97.73%   48, 244
R/getClinicalTrials.R           64       0  100.00%
R/getSimulatedData.R           107       0  100.00%
R/getWaitTimeSum.R              29       2  93.10%   45, 48
R/hazardFunctions.R             26       0  100.00%
R/piecewiseDistribution.R       32       0  100.00%
R/piecewiseHazards.R            18       0  100.00%
R/survivalFunctions.R           96       0  100.00%
R/transitionParameters.R        42       0  100.00%
TOTAL                          517       4  99.23%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/eventTracking.R               +8       0  +0.23%
R/getClinicalTrials.R           +6       0  +100.00%
R/getSimulatedData.R            +5       0  +100.00%
R/hazardFunctions.R            +26       0  +100.00%
R/piecewiseDistribution.R       -1       0  +100.00%
R/piecewiseHazards.R            +1       0  +100.00%
R/survivalFunctions.R          +96       0  +100.00%
TOTAL                         +141       0  +0.29%

Results for commit: f411b7f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@danielinteractive danielinteractive changed the title Fixes #66 66: Add Function to compute average Hazard Ratio OS Sep 21, 2023
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @holgstr ! please see few comments below

R/hazardFunctions.R Outdated Show resolved Hide resolved
R/hazardFunctions.R Outdated Show resolved Hide resolved
R/hazardFunctions.R Outdated Show resolved Hide resolved
R/hazardFunctions.R Outdated Show resolved Hide resolved
R/hazardFunctions.R Outdated Show resolved Hide resolved
R/hazardFunctions.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @holgstr , almost there now

tests/testthat/test-hazardFunctions.R Show resolved Hide resolved
R/hazardFunctions.R Outdated Show resolved Hide resolved
R/hazardFunctions.R Outdated Show resolved Hide resolved
R/hazardFunctions.R Show resolved Hide resolved
@holgstr
Copy link
Contributor Author

holgstr commented Sep 21, 2023

@danielinteractive thanks for the comments! I tried with the description, not sure if this is what you meant

@holgstr holgstr merged commit 1dbe4f0 into main Sep 21, 2023
25 checks passed
@holgstr holgstr deleted the ahr-exp-os branch September 21, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function to compute average Hazard Ratio OS
2 participants