-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Trial Planning Vignette #71
Conversation
- renames powerEmp to empSignificant
Dear @danielinteractive, I decided to reproduce scenario 2 from the paper for the vignette. However, I cannot reproduce the required OS sample size according to Schoenfeld (732 in the vignette, 708 in the paper). See also the sample code in the linked issue opened by Kaspar. |
Code Coverage Summary
Diff against main
Results for commit: 0b049b0 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Interesting thanks @holgstr , so is there now new content in the vignette? Or just refactored? I would go first for pure refactoring and then in separate PR add new content. |
Hm, I guess I might have misunderstood what „refactoring“ means? 😄 I have substituted the R code with the newly added functions, renamed the powerEmp function to empSignificance, and along the way rephrased some sentences in the vignette to match the wording of the package/functions better. The only truly new content is the small chunk in the vignette where sample sizes are calculated according to Schoenfeld via rpact. I now see you may prefer me to break up the PR into two smaller ones? Should I do this now or rather keep it in mind going forward? |
I would say the problematic part of it is new where you cannot reproduce the paper let's split this into separate PR. |
Sorry about the confusion Kaspars issue refers to the new addition, let's keep this PR to the refactoring I.e. using the new functions you added etc |
I have left out the addition of computing the sample sizes via Schoenfeld, so this PR now includes only refactoring + renaming powerEmp to empSignificant. |
Refactoring trial planning vignette: