Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve g_lineplot (documentation and features) #350

Closed
kpagacz opened this issue Jan 25, 2022 · 0 comments · Fixed by #840
Closed

Improve g_lineplot (documentation and features) #350

kpagacz opened this issue Jan 25, 2022 · 0 comments · Fixed by #840
Assignees
@edelarua
Labels
enhancement New feature or request sme

Comments

@kpagacz
Copy link
Contributor

kpagacz commented Jan 25, 2022

Issues:

  • It does not support an argument of length zero to whiskers (could easily just not plot the error bars)
  • The description of the whiskers parameter is convoluted - supposedly Must match the names attribute of the interval element in the list returned by sfun. sfun is by default tern::s_summary() which called returns an error:
    image

How is a user supposed to deal with this?
@kpagacz kpagacz added the bug Something isn't working label Jan 25, 2022
@kpagacz kpagacz mentioned this issue Jan 25, 2022
Closed
@shajoezhu shajoezhu added the sme label Aug 16, 2022
@edelarua edelarua self-assigned this Oct 26, 2023
This was referenced Oct 26, 2023
Merged
Merged
@edelarua edelarua added enhancement New feature or request and removed bug Something isn't working labels Oct 26, 2023
edelarua added a commit to insightsengineering/tern that referenced this issue Oct 27, 2023
@edelarua
Improve documentation of whiskers param in g_lineplot (#1110)
2589bb2 
Part of
insightsengineering/teal.modules.clinical#350
edelarua added a commit that referenced this issue Oct 27, 2023
@edelarua
Add option to remove interval in tm_g_lineplot (#840)
323fc0e 
Closes #350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edelarua edelarua

Labels
enhancement New feature or request sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to remove interval in tm_g_lineplot insightsengineering/teal.modules.clinical
3 participants
@shajoezhu @kpagacz @edelarua